Skip to content

Wrap time sleep #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Wrap time sleep #197

wants to merge 1 commit into from

Conversation

@pancak3
Copy link
Contributor

@pancak3 pancak3 commented Sep 9, 2025

No description provided.

@pancak3
Wrap time sleep
ec4c276 
Signed-off-by: Qifan Deng <[email protected]>
@pancak3 pancak3 marked this pull request as ready for review September 9, 2025 13:39
@mayabar
Copy link
Collaborator

mayabar commented Sep 17, 2025

Hi Qifan, @pancak3
We don’t think we need to wrap time.Sleep. The direct call is clear enough and avoids introducing an extra layer of indirection.

@pancak3
Copy link
Contributor Author

pancak3 commented Sep 17, 2025

sure

@pancak3 pancak3 closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pancak3 @mayabar