Additional latency related metrics #237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irar2
requested changes
Oct 28, 2025
Add reportHistogramValue function to be used for reporting values in histogram metrics Signed-off-by: Maya Barnea <[email protected]>
…ference_time_seconds, vllm:request_prefill_time_seconds, and vllm:request_decode_time_seconds Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
…ames Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
…me model name is all tests, refactoring in server start functions Signed-off-by: Maya Barnea <[email protected]>
…ce_time_seconds Signed-off-by: Maya Barnea <[email protected]>
…st for histogram buckets validation Signed-off-by: Maya Barnea <[email protected]>
- Create constants for all metrics - Define all latency related fake metrics in config - Add validation for new fake metrics in config Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
… latency fake metrics Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
mayabar
force-pushed
the
latency-metrics
branch
from
28cff81 to
8d623a9
Compare
|
Fixes #222 |
irar2
approved these changes
Oct 29, 2025
|
/lgtm |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add vllm:e2e_request_latency_seconds, vllm:request_queue_time_seconds, vllm:request_inference_time_seconds, vllm:request_prefill_time_seconds, vllm:request_decode_time_seconds metrics.
Relevant tests were added for streaming and not-streaming scenarios.
In addition, need to add tests for remote prefill/decode - issue #236
Additionally, utils functions from simulator package were moved to a separate file + more refactoring in tests.