Support vllm:max_num_generation_tokens metrics #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… we never return responses with more than one choice, the implementation is basic. Once 'n' request property will be supported - need to change to support real maximum. Added support in fake metrics. Tests added too. Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
…sage and fix, fix arguments in invalid configuration tests. Fix validation of ttft and tpot fake definitions. Signed-off-by: Maya Barnea <[email protected]>
irar2
requested changes
Nov 4, 2025
…x invalid lora test in config, add missing comments Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
Signed-off-by: Maya Barnea <[email protected]>
irar2
approved these changes
Nov 4, 2025
Collaborator
|
/lgtm |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
vllm:max_num_generation_tokensreport same values asvllm:request_generation_tokenssince response always contains only one choice.Fixes #243