pkg: add ability to provide number of choices sampled. #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To add the N parameter, each choice in the response is the same text content. This also helps simplify things a little bit in terms of testing and response construction. Signed-off-by: Madhav Jivrajani <[email protected]>
Signed-off-by: Madhav Jivrajani <[email protected]>
MadhavJivrajani
force-pushed
the
n-request-param
branch
from
d847cd0 to
9318ab1
Compare
Collaborator
|
Hi @MadhavJivrajani, thanks for the PR.
|
Author
|
Thanks! Let me rework it based on your comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To add the
Nparameter, each choice in the response is the same text content.This also helps simplify things a little bit in terms of testing and response construction.
Fixes #249
cc @mayabar