addressed review comments: namings, import ordering and minor refactoring

Signed-off-by: Maroon Ayoub <[email protected]>

Author: vMaroon

examples/kv-cache-aware-scorer/kvcache-aware-scorer.go renamed to examples/kv-cache-aware-scorer/kvcache_aware_scorer.go

@@ -23,13 +23,12 @@ import (
 	"fmt"
 	"os"
 
-	"github.com/llm-d/llm-d-kv-cache-manager/pkg/kvcache"
-
 	"sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins"
 	"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/types"
-
 	logutil "sigs.k8s.io/gateway-api-inference-extension/pkg/epp/util/logging"
+
+	"github.com/llm-d/llm-d-kv-cache-manager/pkg/kvcache"
 )
 
 const (

examples/kv-cache-index/main.go

@@ -21,9 +21,9 @@ import (
 	"os"
 	"time"
 
-	"github.com/llm-d/llm-d-kv-cache-manager/pkg/kvcache"
-
 	"k8s.io/klog/v2"
+
+	"github.com/llm-d/llm-d-kv-cache-manager/pkg/kvcache"
 )
 
 /*

pkg/kvcache/kvblock/in-memory.go renamed to pkg/kvcache/kvblock/in_memory.go

@@ -19,7 +19,6 @@ package kvblock
 import (
 	"context"
 	"fmt"
-	"time"
 
 	lru "github.com/hashicorp/golang-lru/v2"
 	"k8s.io/apimachinery/pkg/util/sets"
@@ -80,7 +79,7 @@ var _ Index = &InMemoryIndex{}
 type PodCache struct {
 	// cache is an LRU cache that maps PodEntry to their last access time.
 	// thread-safe.
-	cache *lru.Cache[PodEntry, time.Time]
+	cache *lru.Cache[PodEntry, struct{}]
 }
 
 // Lookup receives a list of keys and a set of pod identifiers,
@@ -148,22 +147,20 @@ func (m *InMemoryIndex) Add(ctx context.Context, keys []Key, entries []PodEntry)
 	for _, key := range keys {
 		podCache, found := m.data.Get(key) // bumps LRU timestamp if found
 		if !found {
-			cache, err := lru.New[PodEntry, time.Time](m.podCacheSize)
+			cache, err := lru.New[PodEntry, struct{}](m.podCacheSize)
 			if err != nil {
 				return fmt.Errorf("failed to create pod cache for key %s: %w", key.String(), err)
 			}
 
 			podCache = &PodCache{
 				cache: cache,
 			}
-		}
 
-		for _, entry := range entries {
-			podCache.cache.Add(entry, time.Now()) // TODO: can this be batched to avoid multiple locks?
+			m.data.ContainsOrAdd(key, podCache)
 		}
 
-		if !found {
-			m.data.Add(key, podCache) // TODO: conflicts here can lead to lost updates, fix locking
+		for _, entry := range entries {
+			podCache.cache.Add(entry, struct{}{}) // TODO: can this be batched to avoid multiple locks?
 		}
 
 		traceLogger.Info("added pods to key", "key", key, "pods", entries)