Skip to content

Commit fce7a62

Browse files
committed
address review
Signed-off-by: Maroon Ayoub <[email protected]>
1 parent 4e455e9 commit fce7a62

File tree

2 files changed

+17
-4
lines changed

2 files changed

+17
-4
lines changed

docs/configuration.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -335,8 +335,8 @@ Configures the available device backends which store the KV Cache blocks. This w
335335
### KV-Event Pool Configuration (`Config`)
336336

337337
Configures the ZMQ event processing pool for handling KV cache events. The pool supports two modes:
338-
1. **Global Socket Mode**: Connects to a single ZMQ endpoint
339-
2. **Pod Reconciler Mode** (default): Automatically discovers and subscribes to per-pod ZMQ endpoints
338+
1. **Static Endpoint Mode**: Connects to a single ZMQ endpoint
339+
2. **Auto-Discovery Mode** (default): Automatically discovers and subscribes to per-pod ZMQ endpoints
340340

341341
```json
342342
{
@@ -354,7 +354,7 @@ Configures the ZMQ event processing pool for handling KV cache events. The pool
354354
| `discoverPods` | `boolean` | Enable Kubernetes pod reconciler for automatic per-pod subscriber management | `true` |
355355
| `podDiscoveryConfig` | [PodDiscoveryConfig](#pod-discovery-configuration-podDiscoveryConfig) | Configuration for pod reconciler (only used when `discoverPods` is true) | `null` |
356356

357-
#### Global Socket Mode Example
357+
#### Static Endpoint Mode Example
358358

359359
For connecting to a single ZMQ endpoint:
360360

@@ -369,7 +369,7 @@ For connecting to a single ZMQ endpoint:
369369

370370
The `zmqEndpoint` field specifies the **local** ZMQ socket address to **bind** to.
371371

372-
#### Pod Reconciler Mode Example
372+
#### Auto-Discovery Mode Example
373373

374374
For automatic Kubernetes pod discovery:
375375

examples/kv_cache_aware_scorer/kvcache_aware_scorer.go

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,18 @@
11
//go:build exclude
22

3+
/*
4+
Copyright 2025 The llm-d Authors.
5+
Licensed under the Apache License, Version 2.0 (the "License");
6+
you may not use this file except in compliance with the License.
7+
You may obtain a copy of the License at
8+
http://www.apache.org/licenses/LICENSE-2.0
9+
Unless required by applicable law or agreed to in writing, software
10+
distributed under the License is distributed on an "AS IS" BASIS,
11+
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
See the License for the specific language governing permissions and
13+
limitations under the License.
14+
*/
15+
316
package scorer
417

518
import (

0 commit comments

Comments
 (0)