Merge pull request #711 from lionelvillard/viper

cleanup: use viper to handle config priority

Author: lionelvillard

AGENTS.md

@@ -68,6 +68,7 @@ There are 3 main types of documentation targeting different audiences:
 ## E2E Testing
 
 - use make targets for running e2e tests (e.g., `make test-e2e`) and document the process in `docs/developer-guide/testing.md`
+- use `make test` for unit tests
 - **Never use images from docker.io in e2e tests.** All container images must use fully-qualified registry paths (e.g., `registry.k8s.io/`, `quay.io/`, or a private registry). Do not rely on Docker Hub as a default registry.
 
 ## CLI Tools

cmd/main.go

@@ -169,32 +169,10 @@ func main() {
 		os.Exit(1)
 	}
 
-	// Create StaticConfigFlags from parsed flags
-	// For boolean and duration flags, pass pointers to distinguish "unset" from "explicitly set"
-	flags := config.StaticConfigFlags{
-		MetricsAddr:          metricsAddr,
-		ProbeAddr:            probeAddr,
-		EnableLeaderElection: &enableLeaderElection,
-		LeaderElectionID:     "72dd1cf1.llm-d.ai", // Default, can be overridden via env/ConfigMap
-		LeaseDuration:        &leaseDuration,
-		RenewDeadline:        &renewDeadline,
-		RetryPeriod:          &retryPeriod,
-		RestTimeout:          &restTimeout,
-		SecureMetrics:        &secureMetrics,
-		EnableHTTP2:          &enableHTTP2,
-		WatchNamespace:       watchNamespace,
-		LoggerVerbosity:      loggerVerbosity,
-		WebhookCertPath:      webhookCertPath,
-		WebhookCertName:      webhookCertName,
-		WebhookCertKey:       webhookCertKey,
-		MetricsCertPath:      metricsCertPath,
-		MetricsCertName:      metricsCertName,
-		MetricsCertKey:       metricsCertKey,
-	}
-
 	// Load unified configuration (fail-fast if invalid)
+	// Viper resolves precedence: flags > env > ConfigMap > defaults
 	ctx := context.Background()
-	cfg, err := config.Load(ctx, flags, tempClient)
+	cfg, err := config.Load(ctx, flag.CommandLine, tempClient)
 	if err != nil {
 		setupLog.Error(err, "failed to load configuration - this is a fatal error")
 		os.Exit(1)

docs/developer-guide/configuration.md

@@ -0,0 +1,18 @@
+## Unified Configuration System
+
+WVA uses a unified configuration system that consolidates all settings into a single `Config` structure. This provides clear precedence rules, type safety, and separation between static (immutable) and dynamic (runtime-updatable) configuration.
+
+### Configuration Structure
+
+The unified `Config` consists of two parts:
+
+1. **StaticConfig**: Immutable settings loaded at startup (require controller restart to change)
+   - Infrastructure settings (metrics/probe addresses, leader election)
+   - Connection settings (Prometheus URL, TLS certificates)
+   - Feature flags
+
+2. **DynamicConfig**: Runtime-updatable settings (can be changed via ConfigMap updates)
+   - Optimization interval
+   - Saturation scaling thresholds
+   - Scale-to-zero configuration
+   - Prometheus cache settings

docs/user-guide/configuration.md

@@ -126,79 +126,34 @@ See [Saturation Analyzer Documentation](../../docs/saturation-analyzer.md) for c
 
 WVA uses ConfigMaps for cluster-wide configuration.
 
-### Service Class ConfigMap
-
-Defines SLO requirements for different service tiers:
-
-```yaml
-apiVersion: v1
-kind: ConfigMap
-metadata:
-  name: serviceclass
-  namespace: workload-variant-autoscaler-system
-data:
-  serviceClasses: |
-    - name: Premium
-      model: meta/llama-3.1-8b
-      priority: 1
-      slo-itl: 24        # Time per output token (ms)
-      slo-ttw: 500       # Time to first token (ms)
-      
-    - name: Standard
-      model: meta/llama-3.1-8b
-      priority: 5
-      slo-itl: 50
-      slo-ttw: 1000
-      
-    - name: Freemium
-      model: meta/llama-3.1-8b
-      priority: 10
-      slo-itl: 100
-      slo-ttw: 2000
-```
-
-## Unified Configuration System
-
-WVA uses a unified configuration system that consolidates all settings into a single `Config` structure. This provides clear precedence rules, type safety, and separation between static (immutable) and dynamic (runtime-updatable) configuration.
-
-### Configuration Structure
-
-The unified `Config` consists of two parts:
-
-1. **StaticConfig**: Immutable settings loaded at startup (require controller restart to change)
-   - Infrastructure settings (metrics/probe addresses, leader election)
-   - Connection settings (Prometheus URL, TLS certificates)
-   - Feature flags
-
-2. **DynamicConfig**: Runtime-updatable settings (can be changed via ConfigMap updates)
-   - Optimization interval
-   - Saturation scaling thresholds
-   - Scale-to-zero configuration
-   - Prometheus cache settings
-
 ### Configuration Precedence
 
-Configuration values are loaded with the following precedence (highest to lowest):
+Configuration values are resolved with following precedence (highest to lowest):
 
-1. **CLI Flags** (highest priority)
+1. **CLI Flags** — only when explicitly set on the command line (highest priority)
 2. **Environment Variables**
 3. **ConfigMap** (in `workload-variant-autoscaler-system` namespace)
 4. **Defaults** (lowest priority)
 
+> **Note:** CLI flag defaults do **not** override environment variables or ConfigMap values.
+> Only flags that are explicitly passed on the command line take precedence.
+> For example, if `--leader-elect` is not passed but `LEADER_ELECT=true` is set in
+> the environment, the environment value (`true`) is used.
+
 **Example:**
 ```bash
-# CLI flag (highest priority)
---metrics-addr=":8443"
+# CLI flag explicitly set (highest priority)
+--metrics-bind-address=":8443"
 
-# Environment variable (overridden by flags)
+# Environment variable (used when flag is not explicitly set)
 export METRICS_BIND_ADDRESS=":8080"
 
-# ConfigMap (overridden by env/flags)
+# ConfigMap (used when neither flag nor env is set)
 # wva-variantautoscaling-config
 data:
   METRICS_BIND_ADDRESS: ":9090"
 
-# Default (used if none of above are set)
+# Default (used if none of the above are set)
 # Default: "0" (disabled)
 ```
 
@@ -457,10 +412,10 @@ metadata:
 data:
   # Mutable: Optimization interval (can be changed at runtime)
   GLOBAL_OPT_INTERVAL: "60s"
-  
+
   # Immutable: Prometheus connection (requires restart if changed)
   PROMETHEUS_BASE_URL: "https://prometheus:9090"
-  
+
   # Immutable: Feature flags (require restart if changed)
   WVA_SCALE_TO_ZERO: "true"
   WVA_LIMITED_MODE: "false"
@@ -478,11 +433,11 @@ env:
   # Prometheus connection (immutable - requires restart to change)
   - name: PROMETHEUS_BASE_URL
     value: "https://prometheus:9090"
-  
+
   # Optional: Override ConfigMap name
   - name: CONFIG_MAP_NAME
     value: "my-custom-config"
-  
+
   # Optional: Override namespace
   - name: POD_NAMESPACE
     value: "workload-variant-autoscaler-system"
@@ -492,19 +447,51 @@ env:
 
 ### Configuration via CLI Flags
 
-Infrastructure settings can be configured via CLI flags (highest precedence):
+Infrastructure settings can be configured via CLI flags. Only flags explicitly passed on the command line take highest precedence; unset flags fall through to environment variables, ConfigMap, and then defaults.
 
 ```bash
 # Start controller with custom settings
 ./manager \
-  --metrics-addr=":8443" \
-  --probe-addr=":8081" \
-  --enable-leader-election \
-  --leader-election-id="my-election-id"
+  --metrics-bind-address=":8443" \
+  --health-probe-bind-address=":8081" \
+  --leader-elect \
+  --leader-election-lease-duration=60s \
+  --leader-election-renew-deadline=50s \
+  --leader-election-retry-period=10s \
+  --rest-client-timeout=60s
 ```
 
+### Configuration Parameter Reference
+
+The following table lists all static configuration parameters with their CLI flag, environment variable, ConfigMap key, type, and default value. All three sources share the same key name (except CLI flags which use kebab-case).
+
 **Note:** CLI flags are typically set in the Helm chart or deployment manifest, not directly.
 
+| Parameter | CLI Flag | Env Var / ConfigMap Key | Type | Default | Description |
+|-----------|----------|------------------------|------|---------|-------------|
+| Metrics bind address | `--metrics-bind-address` | `METRICS_BIND_ADDRESS` | string | `0` | Metrics endpoint bind address (`:8443` for HTTPS, `:8080` for HTTP, `0` to disable) |
+| Health probe address | `--health-probe-bind-address` | `HEALTH_PROBE_BIND_ADDRESS` | string | `:8081` | Health probe endpoint bind address |
+| Leader election | `--leader-elect` | `LEADER_ELECT` | bool | `false` | Enable leader election for HA |
+| Leader election ID | — | `LEADER_ELECTION_ID` | string | `72dd1cf1.llm-d.ai` | Leader election coordination ID |
+| Lease duration | `--leader-election-lease-duration` | `LEADER_ELECTION_LEASE_DURATION` | duration | `60s` | Duration non-leaders wait before force-acquiring leadership |
+| Renew deadline | `--leader-election-renew-deadline` | `LEADER_ELECTION_RENEW_DEADLINE` | duration | `50s` | Duration the leader retries refreshing before giving up |
+| Retry period | `--leader-election-retry-period` | `LEADER_ELECTION_RETRY_PERIOD` | duration | `10s` | Duration between retry attempts |
+| REST timeout | `--rest-client-timeout` | `REST_CLIENT_TIMEOUT` | duration | `60s` | Timeout for Kubernetes API server REST calls |
+| Secure metrics | `--metrics-secure` | `METRICS_SECURE` | bool | `true` | Serve metrics endpoint via HTTPS |
+| Enable HTTP/2 | `--enable-http2` | `ENABLE_HTTP2` | bool | `false` | Enable HTTP/2 for metrics and webhook servers |
+| Watch namespace | `--watch-namespace` | `WATCH_NAMESPACE` | string | `""` | Namespace to watch (empty = all namespaces) |
+| Log verbosity | `-v` | `V` | int | `2` | Log level verbosity |
+| Webhook cert path | `--webhook-cert-path` | `WEBHOOK_CERT_PATH` | string | `""` | Directory containing the webhook certificate |
+| Webhook cert name | `--webhook-cert-name` | `WEBHOOK_CERT_NAME` | string | `tls.crt` | Webhook certificate file name |
+| Webhook cert key | `--webhook-cert-key` | `WEBHOOK_CERT_KEY` | string | `tls.key` | Webhook key file name |
+| Metrics cert path | `--metrics-cert-path` | `METRICS_CERT_PATH` | string | `""` | Directory containing the metrics server certificate |
+| Metrics cert name | `--metrics-cert-name` | `METRICS_CERT_NAME` | string | `tls.crt` | Metrics server certificate file name |
+| Metrics cert key | `--metrics-cert-key` | `METRICS_CERT_KEY` | string | `tls.key` | Metrics key file name |
+| Scale to zero | — | `WVA_SCALE_TO_ZERO` | bool | `false` | Enable scale-to-zero feature |
+| Limited mode | — | `WVA_LIMITED_MODE` | bool | `false` | Enable limited mode |
+| Scale-from-zero concurrency | — | `SCALE_FROM_ZERO_ENGINE_MAX_CONCURRENCY` | int | `10` | Max concurrent scale-from-zero operations |
+| EPP bearer token | — | `EPP_METRIC_READER_BEARER_TOKEN` | string | `""` | EPP metric reader bearer token |
+
 ### Fail-Fast Validation
 
 WVA implements **fail-fast** validation: if required configuration is missing or invalid, the controller will:
@@ -611,7 +598,7 @@ spec:
 See [CRD Reference](crd-reference.md) for advanced configuration options.
 
 ## Best Practices
- 
+
 ### Environment Variables
 
 WVA supports configuration via environment variables for operational settings:
@@ -737,4 +724,3 @@ For complete documentation, see [Multi-Controller Isolation Guide](multi-control
 - [Run the Quick Start Demo](../tutorials/demo.md)
 - [Integrate with HPA](../integrations/hpa-integration.md)
 - [Set up Prometheus monitoring](../integrations/prometheus.md)
-

go.mod

@@ -6,6 +6,7 @@ require (
 	github.com/onsi/ginkgo/v2 v2.27.2
 	github.com/onsi/gomega v1.38.2
 	github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring v0.78.2
+	github.com/spf13/viper v1.21.0
 	github.com/stretchr/testify v1.11.1
 	k8s.io/apimachinery v0.34.2
 	k8s.io/client-go v0.34.2
@@ -16,7 +17,14 @@ require (
 require (
 	github.com/Masterminds/semver/v3 v3.4.0 // indirect
 	github.com/cenkalti/backoff/v5 v5.0.3 // indirect
+	github.com/go-viper/mapstructure/v2 v2.4.0 // indirect
+	github.com/pelletier/go-toml/v2 v2.2.4 // indirect
 	github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect
+	github.com/sagikazarmark/locafero v0.11.0 // indirect
+	github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 // indirect
+	github.com/spf13/afero v1.15.0 // indirect
+	github.com/spf13/cast v1.10.0 // indirect
+	github.com/subosito/gotenv v1.6.0 // indirect
 	go.opentelemetry.io/auto/sdk v1.1.0 // indirect
 	go.opentelemetry.io/otel/exporters/stdout/stdouttrace v1.38.0 // indirect
 	go.yaml.in/yaml/v2 v2.4.3 // indirect
@@ -65,7 +73,7 @@ require (
 	github.com/prometheus/common v0.67.2
 	github.com/prometheus/procfs v0.17.0 // indirect
 	github.com/spf13/cobra v1.9.1 // indirect
-	github.com/spf13/pflag v1.0.7
+	github.com/spf13/pflag v1.0.10
 	github.com/stoewer/go-strcase v1.3.0 // indirect
 	github.com/x448/float16 v0.8.4 // indirect
 	go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp v0.63.0 // indirect

go.sum

@@ -25,6 +25,8 @@ github.com/evanphx/json-patch/v5 v5.9.11 h1:/8HVnzMq13/3x9TPvjG08wUGqBTmZBsCWzjT
 github.com/evanphx/json-patch/v5 v5.9.11/go.mod h1:3j+LviiESTElxA4p3EMKAB9HXj3/XEtnUf6OZxqIQTM=
 github.com/felixge/httpsnoop v1.0.4 h1:NFTV2Zj1bL4mc9sqWACXbQFVBBg2W3GPvqp8/ESS2Wg=
 github.com/felixge/httpsnoop v1.0.4/go.mod h1:m8KPJKqk1gH5J9DgRY2ASl2lWCfGKXixSwevea8zH2U=
+github.com/frankban/quicktest v1.14.6 h1:7Xjx+VpznH+oBnejlPUj8oUpdxnVs4f8XU8WnHkI4W8=
+github.com/frankban/quicktest v1.14.6/go.mod h1:4ptaffx2x8+WTWXmUCuVU6aPUX1/Mz7zb5vbUoiM6w0=
 github.com/fsnotify/fsnotify v1.9.0 h1:2Ml+OJNzbYCTzsxtv8vKSFD9PbJjmhYF14k/jKC7S9k=
 github.com/fsnotify/fsnotify v1.9.0/go.mod h1:8jBTzvmWwFyi3Pb8djgCCO5IBqzKJ/Jwo8TRcHyHii0=
 github.com/fxamacker/cbor/v2 v2.9.0 h1:NpKPmjDBgUfBms6tr6JZkTHtfFGcMKsw3eGcmD/sapM=
@@ -50,6 +52,8 @@ github.com/go-openapi/swag v0.23.1 h1:lpsStH0n2ittzTnbaSloVZLuB5+fvSY/+hnagBjSNZ
 github.com/go-openapi/swag v0.23.1/go.mod h1:STZs8TbRvEQQKUA+JZNAm3EWlgaOBGpyFDqQnDHMef0=
 github.com/go-task/slim-sprig/v3 v3.0.0 h1:sUs3vkvUymDpBKi3qH1YSqBQk9+9D/8M2mN1vB6EwHI=
 github.com/go-task/slim-sprig/v3 v3.0.0/go.mod h1:W848ghGpv3Qj3dhTPRyJypKRiqCdHZiAzKg9hl15HA8=
+github.com/go-viper/mapstructure/v2 v2.4.0 h1:EBsztssimR/CONLSZZ04E8qAkxNYq4Qp9LvH92wZUgs=
+github.com/go-viper/mapstructure/v2 v2.4.0/go.mod h1:oJDH3BJKyqBA2TXFhDsKDGDTlndYOZ6rGS0BRZIxGhM=
 github.com/goccy/go-yaml v1.18.0 h1:8W7wMFS12Pcas7KU+VVkaiCng+kG8QiFeFwzFb+rwuw=
 github.com/goccy/go-yaml v1.18.0/go.mod h1:XBurs7gK8ATbW4ZPGKgcbrY1Br56PdM69F7LkFRi1kA=
 github.com/gogo/protobuf v1.3.2 h1:Ov1cvc58UF3b5XjBnZv7+opcTcQFZebYjWzi34vdm4Q=
@@ -113,6 +117,8 @@ github.com/onsi/ginkgo/v2 v2.27.2 h1:LzwLj0b89qtIy6SSASkzlNvX6WktqurSHwkk2ipF/Ns
 github.com/onsi/ginkgo/v2 v2.27.2/go.mod h1:ArE1D/XhNXBXCBkKOLkbsb2c81dQHCRcF5zwn/ykDRo=
 github.com/onsi/gomega v1.38.2 h1:eZCjf2xjZAqe+LeWvKb5weQ+NcPwX84kqJ0cZNxok2A=
 github.com/onsi/gomega v1.38.2/go.mod h1:W2MJcYxRGV63b418Ai34Ud0hEdTVXq9NW9+Sx6uXf3k=
+github.com/pelletier/go-toml/v2 v2.2.4 h1:mye9XuhQ6gvn5h28+VilKrrPoQVanw5PMw/TB0t5Ec4=
+github.com/pelletier/go-toml/v2 v2.2.4/go.mod h1:2gIqNv+qfxSVS7cM2xJQKtLSTLUE9V8t9Stt+h56mCY=
 github.com/pkg/errors v0.9.1 h1:FEBLx1zS214owpjy7qsBeixbURkuhQAwrK5UwLGTwt4=
 github.com/pkg/errors v0.9.1/go.mod h1:bwawxfHBFNV+L2hUp1rHADufV3IMtnDRdf1r5NINEl0=
 github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4=
@@ -131,11 +137,21 @@ github.com/prometheus/procfs v0.17.0/go.mod h1:oPQLaDAMRbA+u8H5Pbfq+dl3VDAvHxMUO
 github.com/rogpeppe/go-internal v1.13.1 h1:KvO1DLK/DRN07sQ1LQKScxyZJuNnedQ5/wKSR38lUII=
 github.com/rogpeppe/go-internal v1.13.1/go.mod h1:uMEvuHeurkdAXX61udpOXGD/AzZDWNMNyH2VO9fmH0o=
 github.com/russross/blackfriday/v2 v2.1.0/go.mod h1:+Rmxgy9KzJVeS9/2gXHxylqXiyQDYRxCVz55jmeOWTM=
+github.com/sagikazarmark/locafero v0.11.0 h1:1iurJgmM9G3PA/I+wWYIOw/5SyBtxapeHDcg+AAIFXc=
+github.com/sagikazarmark/locafero v0.11.0/go.mod h1:nVIGvgyzw595SUSUE6tvCp3YYTeHs15MvlmU87WwIik=
+github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8 h1:+jumHNA0Wrelhe64i8F6HNlS8pkoyMv5sreGx2Ry5Rw=
+github.com/sourcegraph/conc v0.3.1-0.20240121214520-5f936abd7ae8/go.mod h1:3n1Cwaq1E1/1lhQhtRK2ts/ZwZEhjcQeJQ1RuC6Q/8U=
+github.com/spf13/afero v1.15.0 h1:b/YBCLWAJdFWJTN9cLhiXXcD7mzKn9Dm86dNnfyQw1I=
+github.com/spf13/afero v1.15.0/go.mod h1:NC2ByUVxtQs4b3sIUphxK0NioZnmxgyCrfzeuq8lxMg=
+github.com/spf13/cast v1.10.0 h1:h2x0u2shc1QuLHfxi+cTJvs30+ZAHOGRic8uyGTDWxY=
+github.com/spf13/cast v1.10.0/go.mod h1:jNfB8QC9IA6ZuY2ZjDp0KtFO2LZZlg4S/7bzP6qqeHo=
 github.com/spf13/cobra v1.9.1 h1:CXSaggrXdbHK9CF+8ywj8Amf7PBRmPCOJugH954Nnlo=
 github.com/spf13/cobra v1.9.1/go.mod h1:nDyEzZ8ogv936Cinf6g1RU9MRY64Ir93oCnqb9wxYW0=
 github.com/spf13/pflag v1.0.6/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
-github.com/spf13/pflag v1.0.7 h1:vN6T9TfwStFPFM5XzjsvmzZkLuaLX+HS+0SeFLRgU6M=
-github.com/spf13/pflag v1.0.7/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
+github.com/spf13/pflag v1.0.10 h1:4EBh2KAYBwaONj6b2Ye1GiHfwjqyROoF4RwYO+vPwFk=
+github.com/spf13/pflag v1.0.10/go.mod h1:McXfInJRrz4CZXVZOBLb0bTZqETkiAhM9Iw0y3An2Bg=
+github.com/spf13/viper v1.21.0 h1:x5S+0EU27Lbphp4UKm1C+1oQO+rKx36vfCoaVebLFSU=
+github.com/spf13/viper v1.21.0/go.mod h1:P0lhsswPGWD/1lZJ9ny3fYnVqxiegrlNrEmgLjbTCAY=
 github.com/stoewer/go-strcase v1.3.0 h1:g0eASXYtp+yvN9fK8sH94oCIk0fau9uV1/ZdJ0AVEzs=
 github.com/stoewer/go-strcase v1.3.0/go.mod h1:fAH5hQ5pehh+j3nZfvwdk2RgEgQjAoM8wodgtPmh1xo=
 github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME=
@@ -149,6 +165,8 @@ github.com/stretchr/testify v1.8.0/go.mod h1:yNjHg4UonilssWZ8iaSj1OCr/vHnekPRkoO
 github.com/stretchr/testify v1.8.1/go.mod h1:w2LPCIKwWwSfY2zedu0+kehJoqGctiVI29o6fzry7u4=
 github.com/stretchr/testify v1.11.1 h1:7s2iGBzp5EwR7/aIZr8ao5+dra3wiQyKjjFuvgVKu7U=
 github.com/stretchr/testify v1.11.1/go.mod h1:wZwfW3scLgRK+23gO65QZefKpKQRnfz6sD981Nm4B6U=
+github.com/subosito/gotenv v1.6.0 h1:9NlTDc1FTs4qu0DDq7AEtTPNw6SVm7uBMsUCUjABIf8=
+github.com/subosito/gotenv v1.6.0/go.mod h1:Dk4QP5c2W3ibzajGcXpNraDfq2IrhjMIvMSWPKKo0FU=
 github.com/tidwall/gjson v1.18.0 h1:FIDeeyB800efLX89e5a8Y0BNH+LOngJyGrIWxG2FKQY=
 github.com/tidwall/gjson v1.18.0/go.mod h1:/wbyibRr2FHMks5tjHJ5F8dMZh3AcwJEMf5vlfC0lxk=
 github.com/tidwall/match v1.1.1 h1:+Ho715JplO36QYgwN9PGYNhgZvoUSc9X2c80KVTi+GA=

internal/config/config.go

@@ -716,8 +716,7 @@ func NewTestConfigWithPrometheus(ctx context.Context, prometheusURL string, k8sC
 	_ = os.Setenv("PROMETHEUS_BASE_URL", prometheusURL)
 	defer func() { _ = os.Unsetenv("PROMETHEUS_BASE_URL") }()
 
-	flags := StaticConfigFlags{}
-	cfg, err := Load(ctx, flags, k8sClient)
+	cfg, err := Load(ctx, nil, k8sClient)
 	if err != nil {
 		return nil, fmt.Errorf("failed to create test config: %w", err)
 	}