Skip to content

Commit da57ae7

Browse files
clubandersonclaude
andauthored
🐛 fix: link GHCR packages to repository and use GITHUB_TOKEN (#698)
Packages were not appearing on the repository page because: 1. The Dockerfile was missing OCI labels (org.opencontainers.image.source) that GitHub uses to auto-link container packages to repositories 2. Release workflows used personal access tokens (secrets.GHCR_TOKEN, secrets.CR_TOKEN) instead of GITHUB_TOKEN. PATs don't trigger the automatic package-to-repository linking that GITHUB_TOKEN provides Changes: - Add OCI labels to Dockerfile for automatic GHCR package linking - Switch ci-release.yaml to use GITHUB_TOKEN with packages:write permission - Switch helm-release.yaml to use GITHUB_TOKEN for Docker and Helm login - Fix remaining llm-d-incubation org references in docs Signed-off-by: Andrew Anderson <andy@clubanderson.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
1 parent c760bb7 commit da57ae7

File tree

5 files changed

+23
-10
lines changed

5 files changed

+23
-10
lines changed

.github/workflows/ci-release.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,10 @@ on:
77
release:
88
types: [published] # Also runs when a GitHub release is published
99

10+
permissions:
11+
contents: read
12+
packages: write
13+
1014
jobs:
1115
docker-build-and-push:
1216
runs-on: ubuntu-latest
@@ -42,7 +46,11 @@ jobs:
4246
uses: docker/setup-buildx-action@v3
4347

4448
- name: Log in to GitHub Container Registry
45-
run: echo "${{ secrets.GHCR_TOKEN }}" | docker login ghcr.io -u ${{ github.actor }} --password-stdin
49+
uses: docker/login-action@v3
50+
with:
51+
registry: ghcr.io
52+
username: ${{ github.actor }}
53+
password: ${{ github.token }}
4654

4755
- name: Build and push multi-arch image
4856
run: |

.github/workflows/helm-release.yaml

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,11 @@ jobs:
7070
# 4. Log in to GHCR for Docker push
7171
# -----------------------------------------
7272
- name: Docker login GHCR
73-
run: echo "${{ secrets.CR_TOKEN }}" | docker login ghcr.io -u ${{ secrets.CR_USER }} --password-stdin
73+
uses: docker/login-action@v3
74+
with:
75+
registry: ghcr.io
76+
username: ${{ github.actor }}
77+
password: ${{ github.token }}
7478

7579
# -----------------------------------------
7680
# 5. Build and push multi-arch Docker image
@@ -121,12 +125,10 @@ jobs:
121125
# 8. Login to GHCR for chart publishing
122126
# -----------------------------------------
123127
- name: Login to GHCR (Helm)
124-
env:
125-
GITHUB_TOKEN: ${{ secrets.CR_TOKEN }}
126128
run: |
127129
helm registry login ghcr.io \
128-
--username ${{ secrets.CR_USER }} \
129-
--password "$GITHUB_TOKEN"
130+
--username ${{ github.actor }} \
131+
--password "${{ github.token }}"
130132
echo "Helm registry login successful"
131133
132134
# -----------------------------------------
@@ -140,8 +142,6 @@ jobs:
140142
# 10. Push chart to GHCR
141143
# -----------------------------------------
142144
- name: Push Helm chart
143-
env:
144-
GITHUB_TOKEN: ${{ secrets.CR_TOKEN }}
145145
run: |
146146
VERSION="${{ steps.version.outputs.version }}"
147147
CHART_FILE="workload-variant-autoscaler-${VERSION}.tgz"

Dockerfile

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,11 @@ RUN CGO_ENABLED=0 GOOS=${TARGETOS:-linux} GOARCH=${TARGETARCH} go build -a -o ma
2727
# Use distroless as minimal base image to package the manager binary
2828
# Refer to https://github.com/GoogleContainerTools/distroless for more details
2929
FROM gcr.io/distroless/static:nonroot
30+
31+
LABEL org.opencontainers.image.source="https://github.com/llm-d/llm-d-workload-variant-autoscaler"
32+
LABEL org.opencontainers.image.description="Workload Variant Autoscaler (WVA) - GPU-aware autoscaler for LLM inference workloads"
33+
LABEL org.opencontainers.image.licenses="Apache-2.0"
34+
3035
WORKDIR /
3136
COPY --from=builder /workspace/manager .
3237
USER 65532:65532

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -205,7 +205,7 @@ Apache 2.0 - see [LICENSE](LICENSE) for details.
205205

206206
## Related Projects
207207

208-
- [llm-d infrastructure](https://github.com/llm-d-incubation/llm-d-infra)
208+
- [llm-d infrastructure](https://github.com/llm-d/llm-d-infra)
209209
- [llm-d main repository](https://github.com/llm-d/llm-d)
210210

211211
## References

docs/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ Contributing to WVA:
5858
## Additional Resources
5959

6060
- [Community Proposal](https://docs.google.com/document/d/1n6SAhloQaoSyF2k3EveIOerT-f97HuWXTLFm07xcvqk/edit)
61-
- [llm-d Infrastructure](https://github.com/llm-d-incubation/llm-d-infra)
61+
- [llm-d Infrastructure](https://github.com/llm-d/llm-d-infra)
6262
- [API Proposal](https://docs.google.com/document/d/1j2KRAT68_FYxq1iVzG0xVL-DHQhGVUZBqiM22Hd_0hc/edit)
6363

6464
## Need Help?

0 commit comments

Comments
 (0)