fix: address CI lint error and add security improvements

- Fix undefined err variable (use loadErr for createParallelLoadJobs)
- Add kubectl SHA256 checksum verification for security
- Improve health check shell script formatting for readability

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: clubanderson

.github/workflows/ci-e2e-openshift.yaml

@@ -164,8 +164,11 @@ jobs:
           KUBECTL_VERSION="v1.31.0"
           echo "Installing kubectl version: $KUBECTL_VERSION"
           curl -fsSL --retry 3 --retry-delay 5 -o kubectl "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl"
+          curl -fsSL --retry 3 --retry-delay 5 -o kubectl.sha256 "https://dl.k8s.io/release/${KUBECTL_VERSION}/bin/linux/amd64/kubectl.sha256"
+          echo "$(cat kubectl.sha256)  kubectl" | sha256sum --check
           chmod +x kubectl
           sudo mv kubectl /usr/local/bin/
+          rm -f kubectl.sha256
           # Install oc (OpenShift CLI)
           curl -fsSL --retry 3 --retry-delay 5 -O "https://mirror.openshift.com/pub/openshift-v4/clients/ocp/stable/openshift-client-linux.tar.gz"
           tar -xzf openshift-client-linux.tar.gz

test/e2e-openshift/sharegpt_scaleup_test.go

@@ -185,7 +185,12 @@ var _ = Describe("ShareGPT Scale-Up Test", Ordered, func() {
 							Name:    "health-check",
 							Image:   "quay.io/curl/curl:8.11.1",
 							Command: []string{"/bin/sh", "-c"},
-							Args: []string{fmt.Sprintf(`echo "Checking vLLM readiness at %s:8200..." && curl -sf --max-time 10 http://%s:8200/v1/models && echo "vLLM is ready!" && exit 0; echo "vLLM not ready yet"; exit 1`, vllmServiceName, vllmServiceName)},
+							Args: []string{fmt.Sprintf(`
+echo "Checking vLLM readiness at %s:8200..."
+curl -sf --max-time 10 http://%s:8200/v1/models && echo "vLLM is ready!" && exit 0
+echo "vLLM not ready yet"
+exit 1`,
+								vllmServiceName, vllmServiceName)},
 						}},
 					},
 				},
@@ -230,8 +235,8 @@ var _ = Describe("ShareGPT Scale-Up Test", Ordered, func() {
 		time.Sleep(2 * time.Second)
 
 		By(fmt.Sprintf("creating %d parallel load generation jobs", numLoadWorkers))
-		err = createParallelLoadJobs(ctx, jobBaseName, llmDNamespace, vllmServiceName, numLoadWorkers, requestsPerWorker)
-		Expect(err).NotTo(HaveOccurred(), "Should be able to create load generation jobs")
+		loadErr := createParallelLoadJobs(ctx, jobBaseName, llmDNamespace, vllmServiceName, numLoadWorkers, requestsPerWorker)
+		Expect(loadErr).NotTo(HaveOccurred(), "Should be able to create load generation jobs")
 
 		By("waiting for job pods to be running")
 		Eventually(func(g Gomega) {