Skip to content

Address TODO Comments - Update FixedSizePool #1044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kab163 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Address TODO Comments - Update FixedSizePool #1044

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/umpire/strategy/FixedSizePool.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,19 @@ class FixedSizePool {

std::size_t numBlocks;

void reversePools()
{
struct Pool* prev = nullptr;
struct Pool* curr = pool;
while (curr) {
struct Pool* next = curr->next;
curr->next = prev;
prev = curr;
curr = next;
}
pool = prev;
}

void newPool(struct Pool **pnew)
{
struct Pool *p = static_cast<struct Pool *>(IA::allocate(sizeof(struct Pool) + NP * sizeof(unsigned int)));
Expand Down Expand Up @@ -109,8 +122,8 @@ class FixedSizePool {

if (!ptr) {
newPool(&prev->next);
reversePools();
ptr = allocate();
// TODO: In this case we should reverse the linked list for optimality
} else {
numBlocks++;
}
Expand Down
Loading