Remove unused RunningState Sent tracking

Signed-off-by: Mathias L. Baumann <[email protected]>

Author: Marenz

src/frequenz/dispatch/_dispatch.py

@@ -17,30 +17,20 @@ class Dispatch(BaseDispatch):
     deleted: bool = False
     """Whether the dispatch is deleted."""
 
-    running_state_change_synced: datetime | None = None
-    """The last time a message was sent about the running state change."""
-
     def __init__(
         self,
         client_dispatch: BaseDispatch,
         deleted: bool = False,
-        running_state_change_synced: datetime | None = None,
     ):
         """Initialize the dispatch.
 
         Args:
             client_dispatch: The client dispatch.
             deleted: Whether the dispatch is deleted.
-            running_state_change_synced: Timestamp of the last running state change message.
         """
         super().__init__(**client_dispatch.__dict__)
         # Work around frozen to set deleted
         object.__setattr__(self, "deleted", deleted)
-        object.__setattr__(
-            self,
-            "running_state_change_synced",
-            running_state_change_synced,
-        )
 
     def _set_deleted(self) -> None:
         """Mark the dispatch as deleted."""
@@ -58,40 +48,24 @@ def started(self) -> bool:
 
         return super().started
 
-    @property
-    def _running_status_notified(self) -> bool:
-        """Check that the latest running state change notification was sent.
-
-        Returns:
-            True if the latest running state change notification was sent, False otherwise.
-        """
-        return self.running_state_change_synced == self.update_time
-
-    def _set_running_status_notified(self) -> None:
-        """Mark the latest running state change notification as sent."""
-        object.__setattr__(self, "running_state_change_synced", self.update_time)
-
-    @property
     # noqa is needed because of a bug in pydoclint that makes it think a `return` without a return
     # value needs documenting
-    def missed_runs(self) -> Iterator[datetime]:  # noqa: DOC405
+    def missed_runs(self, since: datetime) -> Iterator[datetime]:  # noqa: DOC405
         """Yield all missed runs of a dispatch.
 
         Yields all missed runs of a dispatch.
 
-        If a running state change notification was not sent in time
-        due to connection issues, this method will yield all missed runs
-        since the last sent notification.
+        Args:
+            since: The time to start checking for missed runs.
 
         Returns:
             A generator that yields all missed runs of a dispatch.
-        """
-        if self.update_time == self.running_state_change_synced:
-            return
 
-        from_time = self.update_time
+        Yields:
+            datetime: The missed run.
+        """
         now = datetime.now(tz=timezone.utc)
 
-        while (next_run := self.next_run_after(from_time)) and next_run < now:
+        while (next_run := self.next_run_after(since)) and next_run < now:
             yield next_run
-            from_time = next_run
+            since = next_run

src/frequenz/dispatch/actor.py

@@ -359,6 +359,3 @@ async def _send_running_state_change(self, dispatch: Dispatch) -> None:
             dispatch: The dispatch that changed.
         """
         await self._running_state_change_sender.send(dispatch)
-        # Update the last sent notification time
-        # so we know if this change was already sent
-        dispatch._set_running_status_notified()  # pylint: disable=protected-access

tests/test_frequenz_dispatch.py

@@ -144,8 +144,6 @@ async def _test_new_dispatch_created(
             assert False, "Expected a created event"
         case Created(dispatch):
             received = Dispatch(update_dispatch(sample, dispatch))
-            received._set_running_status_notified()  # pylint: disable=protected-access
-            dispatch._set_running_status_notified()  # pylint: disable=protected-access
             assert dispatch == received
 
     return dispatch
@@ -184,10 +182,7 @@ async def test_existing_dispatch_updated(
         case Created(dispatch) | Deleted(dispatch):
             assert False, f"Expected an updated event, got {dispatch_event}"
         case Updated(dispatch):
-            assert dispatch == Dispatch(
-                updated,
-                running_state_change_synced=dispatch.running_state_change_synced,
-            )
+            assert dispatch == Dispatch(updated)
 
     await asyncio.sleep(1)
 
@@ -212,7 +207,6 @@ async def test_existing_dispatch_deleted(
             assert False, "Expected a deleted event"
         case Deleted(dispatch):
             sample._set_deleted()  # pylint: disable=protected-access
-            dispatch._set_running_status_notified()  # pylint: disable=protected-access
             assert dispatch == sample
 
 
@@ -352,9 +346,6 @@ async def test_dispatch_schedule(
     # Expect notification of the dispatch being ready to run
     ready_dispatch = await actor_env.running_state_change.receive()
 
-    # Set flag we expect to be different to compare the dispatch with the one received
-    dispatch._set_running_status_notified()  # pylint: disable=protected-access
-
     assert ready_dispatch == dispatch
 
     assert dispatch.duration is not None