Stop popped fetchers as well

shsms · shsms · commit 6a1d39f06301 · 2025-01-23T14:56:15.000+01:00
Signed-off-by: Sahas Subramanian &lt;sahas.subramanian@proton.me&gt;
diff --git a/src/frequenz/sdk/timeseries/battery_pool/_methods.py b/src/frequenz/sdk/timeseries/battery_pool/_methods.py
@@ -189,7 +189,8 @@ def _remove_metric_fetcher(self, component_id: int) -> None:
             component_id,
             self._result_channel._name,  # pylint: disable=protected-access
         )
-        self._fetchers.pop(component_id)
+        fetcher = self._fetchers.pop(component_id)
+        fetcher.stop()
 
     def _metric_updated(self, new_metrics: ComponentMetricsData) -> bool:
         cid = new_metrics.component_id

Original file line number	Diff line number	Diff line change
`@@ -189,7 +189,8 @@ def _remove_metric_fetcher(self, component_id: int) -> None:`
`189`	`189`	`component_id,`
`190`	`190`	`self._result_channel._name, # pylint: disable=protected-access`
`191`	`191`	`)`
`192`		`- self._fetchers.pop(component_id)`
	`192`	`+ fetcher = self._fetchers.pop(component_id)`
	`193`	`+ fetcher.stop()`
`193`	`194`
`194`	`195`	`def _metric_updated(self, new_metrics: ComponentMetricsData) -> bool:`
`195`	`196`	`cid = new_metrics.component_id`