Skip to content

Commit e98da18

Browse files
authored
Don't fallback to CHPs (frequenz-floss#1161)
Neither the client nor the data sourcing actor support reading data from CHPs. So we can't fallback to CHPs yet.
2 parents bceccfc + e58a737 commit e98da18

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

RELEASE_NOTES.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,3 +15,5 @@
1515
## Bug Fixes
1616

1717
- Fixed a bug that was preventing power proposals to go through if there once existed some proposals with overlapping component IDs, even if the old proposals have expired.
18+
19+
- Fixed a bug that was causing formulas to fallback to CHPs, when the CHP meters didn't have data. CHPs are not supported in the data sourcing actor and in the client, so we can't fallback to CHPs.

src/frequenz/sdk/timeseries/formula_engine/_formula_generators/_formula_generator.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,7 @@ def _get_meter_fallback_components(self, meter: Component) -> set[Component]:
215215

216216
# All fallbacks has to be of the same type and category.
217217
if (
218-
all(graph.is_chp(c) for c in successors)
219-
or all(graph.is_pv_inverter(c) for c in successors)
218+
all(graph.is_pv_inverter(c) for c in successors)
220219
or all(graph.is_battery_inverter(c) for c in successors)
221220
or all(graph.is_ev_charger(c) for c in successors)
222221
):

0 commit comments

Comments
 (0)