Skip to content

Commit 1f0964f

Browse files
committed
[llvm][Docs] Clarify finding maintainers
By noting where the files are to be found, and adding some whitespace to break up large blocks. (the merge on behalf bit needs a refresh but this will go into review later after this)
1 parent 25653e5 commit 1f0964f

File tree

1 file changed

+11
-7
lines changed

1 file changed

+11
-7
lines changed

llvm/docs/Contributing.rst

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -94,13 +94,17 @@ For more information about the workflow of using GitHub Pull Requests see our
9494
`LLVM's Phabricator <https://reviews.llvm.org>`_ instance.
9595

9696
To make sure the right people see your patch, please select suitable reviewers
97-
and add them to your patch when requesting a review. Suitable reviewers are the
98-
maintainers (see ``Maintainers.rst``) and other people doing work in the area your
99-
patch touches. Github will normally suggest some reviewers based on rules or
100-
people that have worked on the code before. If you are a new contributor, you
101-
will not be able to select reviewers in such a way, in which case you can still
102-
get the attention of potential reviewers by CC'ing them in a comment -- just
103-
@name them.
97+
and add them to your patch when requesting a review.
98+
99+
Suitable reviewers are the maintainers of the project you are modifying, and
100+
anyone else working in the area your patch touches. To find maintainers, look for
101+
the ``Maintainers.md`` or ``Maintainers.rst`` file in the root of the project's
102+
sub-directory. For example, LLVM's is ``llvm/Maintainers.md`` and Clang's is
103+
``clang/Maintainers.rst``.
104+
105+
If you are a new contributor, you will not be able to select reviewers in such a
106+
way, in which case you can still get the attention of potential reviewers by CC'ing
107+
them in a comment -- just @name them.
104108

105109
If you have received no comments on your patch for a week, you can request a
106110
review by 'ping'ing the GitHub PR with "Ping". The common courtesy 'ping' rate

0 commit comments

Comments
 (0)