Reland "[lldb][Modules] Fix error handling of parseAndLoadModuleMapFile (llvm#141220)"

This reverts commit 57f3151.

LLDB was hitting an assert when compiling the `std` module. The `std`
module was being pulled in because we use `#import <cstdio>` in the test
to set a breakpoint on `puts`. That's redundant and to work around the
crash we just remove that include. The underlying issue of compiling the
`std` module still exists and I'll investigate that separately. The
reason it started failing after the `ClangModulesDeclVendor` patch is that we would previously just fail to load the modulemap (and thus not load any of the modules). Now we do load the modulemap (and modules) when we prepare for parsing the expression.

Author: Michael137

lldb/source/Plugins/ExpressionParser/Clang/ClangModulesDeclVendor.cpp

@@ -330,7 +330,7 @@ bool ClangModulesDeclVendorImpl::AddModule(const SourceModule &module,
       auto file = HS.lookupModuleMapFile(*dir, is_framework);
       if (!file)
         return error();
-      if (!HS.parseAndLoadModuleMapFile(*file, is_system))
+      if (HS.parseAndLoadModuleMapFile(*file, is_system))
         return error();
     }
   }

lldb/test/API/lang/cpp/gmodules/template-with-same-arg/TestTemplateWithSameArg.py

@@ -34,7 +34,7 @@ def setUp(self):
 
     @add_test_categories(["gmodules"])
     def test_same_template_arg(self):
-        lldbutil.run_to_source_breakpoint(self, "Break here", self.main_source_file)
+        lldbutil.run_to_source_breakpoint(self, "return 0", self.main_source_file)
 
         self.expect_expr(
             "FromMod1",
@@ -58,7 +58,7 @@ def test_same_template_arg(self):
 
     @add_test_categories(["gmodules"])
     def test_duplicate_decls(self):
-        lldbutil.run_to_source_breakpoint(self, "Break here", self.main_source_file)
+        lldbutil.run_to_source_breakpoint(self, "return 0", self.main_source_file)
 
         self.expect_expr("(intptr_t)&FromMod1 + (intptr_t)&FromMod2")
 

lldb/test/API/lang/cpp/gmodules/template-with-same-arg/main.cpp

@@ -1,15 +1,12 @@
 #include "module1.h"
 #include "module2.h"
 
-#include <cstdio>
-
 int main() {
   ClassInMod1 FromMod1;
   ClassInMod2 FromMod2;
 
   FromMod1.VecInMod1.Member = 137;
   FromMod2.VecInMod2.Member = 42;
 
-  std::puts("Break here");
   return 0;
 }