Skip to content

Commit 20a8624

Browse files
committed
[CIR][Github] Attempt to fix windows bots
1 parent 61051cf commit 20a8624

File tree

4 files changed

+7
-16
lines changed

4 files changed

+7
-16
lines changed

.ci/monolithic-windows.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,15 @@ function at-exit {
3232

3333
# If building fails there will be no results files.
3434
shopt -s nullglob
35-
35+
3636
python "${MONOREPO_ROOT}"/.ci/generate_test_report_github.py ":window: Windows x64 Test Results" \
3737
$retcode "${BUILD_DIR}"/test-results.*.xml >> $GITHUB_STEP_SUMMARY
3838
}
3939
trap at-exit EXIT
4040

4141
projects="${1}"
4242
targets="${2}"
43+
enable_cir="${3}"
4344

4445
echo "::group::cmake"
4546
pip install -q -r "${MONOREPO_ROOT}"/.ci/all_requirements.txt
@@ -59,6 +60,7 @@ cmake -S "${MONOREPO_ROOT}"/llvm -B "${BUILD_DIR}" \
5960
-D LLVM_ENABLE_PROJECTS="${projects}" \
6061
-G Ninja \
6162
-D CMAKE_BUILD_TYPE=Release \
63+
-D CLANG_ENABLE_CIR=${enable_cir} \
6264
-D LLVM_ENABLE_ASSERTIONS=ON \
6365
-D LLVM_BUILD_EXAMPLES=ON \
6466
-D COMPILER_RT_BUILD_LIBFUZZER=OFF \

.github/workflows/clang-cir-tests.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,3 +36,4 @@ jobs:
3636
build_target: check-clang-cir
3737
projects: clang;mlir
3838
extra_cmake_args: -DCLANG_ENABLE_CIR=ON
39+
os_list: '["ubuntu-24.04", "windows-2019", "macOS-13"]'

.github/workflows/llvm-project-tests.yml

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -39,24 +39,13 @@ on:
3939
type: string
4040
# Use windows-2019 due to:
4141
# https://developercommunity.visualstudio.com/t/Prev-Issue---with-__assume-isnan-/1597317
42-
# Use ubuntu-22.04 rather than ubuntu-24.04 to match the ubuntu
43-
# version in the CI container. Without this, setup-python tries
44-
# to install a python version linked against a newer version of glibc.
45-
# TODO(boomanaiden154): Bump the Ubuntu version once the version in the
46-
# container is bumped.
47-
default: '["ubuntu-22.04", "windows-2019", "macOS-13"]'
42+
default: '["ubuntu-24.04", "windows-2019", "macOS-13"]'
4843

4944
python_version:
5045
required: false
5146
type: string
5247
default: '3.11'
5348

54-
# Optional reference to the branch being checked out.
55-
# Uses the current branch if not specified.
56-
repo_ref:
57-
required: false
58-
type: string
59-
6049
concurrency:
6150
# Skip intermediate builds: always.
6251
# Cancel intermediate builds: only if it is a pull request build.
@@ -99,10 +88,9 @@ jobs:
9988
# clean: false.
10089
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
10190
with:
102-
ref: ${{ inputs.repo_ref || github.ref }}
10391
fetch-depth: 250
10492
- name: Setup ccache
105-
uses: hendrikmuhs/ccache-action@63069e3931dedbf3b63792097479563182fe70d1 # v1.2.18
93+
uses: hendrikmuhs/ccache-action@a1209f81afb8c005c13b4296c32e363431bffea5 # v1.2.17
10694
with:
10795
# A full build of llvm, clang, lld, and lldb takes about 250MB
10896
# of ccache space. There's not much reason to have more than this,

.github/workflows/premerge.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ jobs:
113113
shell: cmd
114114
run: |
115115
call C:\\BuildTools\\Common7\\Tools\\VsDevCmd.bat -arch=amd64 -host_arch=amd64
116-
bash .ci/monolithic-windows.sh "${{ steps.vars.outputs.windows-projects }}" "${{ steps.vars.outputs.windows-check-targets }}"
116+
bash .ci/monolithic-windows.sh "${{ steps.vars.outputs.windows-projects }}" "${{ steps.vars.outputs.windows-check-targets }}" "${enable_cir}"
117117
- name: Upload Artifacts
118118
if: '!cancelled()'
119119
uses: actions/upload-artifact@65c4c4a1ddee5b72f698fdd19549f0f0fb45cf08 # v4.6.0

0 commit comments

Comments
 (0)