Skip to content

Commit bac4b5c

Browse files
AmrDeveloperlanza
authored andcommitted
[CIR][CIRGen][Builtin][Neon] Lower neon_vsubd_s64 and neon_vsubd_u64 (#1256)
Lowering `neon_vsubd_s64` and `neon_vsubd_u64` - [Clang CGBuiltin Implementation](https://github.com/llvm/clangir/blob/2b1a638ea07ca10c5727ea835bfbe17b881175cc/clang/lib/CodeGen/CGBuiltin.cpp#L12463-L12465) - [vaddd_s64 Builtin definition](https://developer.arm.com/architectures/instruction-sets/intrinsics/vsubd_s64) - [vaddd_u64 Builtin definition](https://developer.arm.com/architectures/instruction-sets/intrinsics/vsubd_u64)
1 parent 06d1ac4 commit bac4b5c

File tree

2 files changed

+23
-13
lines changed

2 files changed

+23
-13
lines changed

clang/lib/CIR/CodeGen/CIRGenBuiltinAArch64.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3790,7 +3790,7 @@ CIRGenFunction::emitAArch64BuiltinExpr(unsigned BuiltinID, const CallExpr *E,
37903790
return builder.createAdd(Ops[0], emitScalarExpr(E->getArg(1)));
37913791
case NEON::BI__builtin_neon_vsubd_s64:
37923792
case NEON::BI__builtin_neon_vsubd_u64:
3793-
llvm_unreachable("NEON::BI__builtin_neon_vsubd_u64 NYI");
3793+
return builder.createSub(Ops[0], emitScalarExpr(E->getArg(1)));
37943794
case NEON::BI__builtin_neon_vqdmlalh_s16:
37953795
case NEON::BI__builtin_neon_vqdmlslh_s16: {
37963796
llvm_unreachable("NEON::BI__builtin_neon_vqdmlslh_s16 NYI");

clang/test/CIR/CodeGen/AArch64/neon.c

Lines changed: 22 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -9905,19 +9905,29 @@ uint64_t test_vaddd_u64(uint64_t a, uint64_t b) {
99059905
// LLVM: ret i64 [[VADDD_I]]
99069906
}
99079907

9908-
// NYI-LABEL: @test_vsubd_s64(
9909-
// NYI: [[VSUBD_I:%.*]] = sub i64 %a, %b
9910-
// NYI: ret i64 [[VSUBD_I]]
9911-
// int64_t test_vsubd_s64(int64_t a, int64_t b) {
9912-
// return vsubd_s64(a, b);
9913-
// }
9908+
int64_t test_vsubd_s64(int64_t a, int64_t b) {
9909+
return vsubd_s64(a, b);
99149910

9915-
// NYI-LABEL: @test_vsubd_u64(
9916-
// NYI: [[VSUBD_I:%.*]] = sub i64 %a, %b
9917-
// NYI: ret i64 [[VSUBD_I]]
9918-
// uint64_t test_vsubd_u64(uint64_t a, uint64_t b) {
9919-
// return vsubd_u64(a, b);
9920-
// }
9911+
// CIR-LABEL: vsubd_s64
9912+
// CIR: {{%.*}} = cir.binop(sub, {{%.*}}, {{%.*}}) : !s64i
9913+
9914+
// LLVM-LABEL: @test_vsubd_s64
9915+
// LLVM-SAME: (i64 [[a:%.]], i64 [[b:%.]])
9916+
// LLVM: [[VSUBD_I:%.*]] = sub i64 [[a]], [[b]]
9917+
// LLVM: ret i64 [[VSUBD_I]]
9918+
}
9919+
9920+
uint64_t test_vsubd_u64(uint64_t a, uint64_t b) {
9921+
return vsubd_u64(a, b);
9922+
9923+
// CIR-LABEL: vsubd_u64
9924+
// CIR: {{%.*}} = cir.binop(sub, {{%.*}}, {{%.*}}) : !u64i
9925+
9926+
// LLVM-LABEL: @test_vsubd_u64
9927+
// LLVM-SAME: (i64 [[a:%.]], i64 [[b:%.]])
9928+
// LLVM: [[VSUBD_I:%.*]] = sub i64 [[a]], [[b]]
9929+
// LLVM: ret i64 [[VSUBD_I]]
9930+
}
99219931

99229932
// NYI-LABEL: @test_vqaddb_s8(
99239933
// NYI: [[TMP0:%.*]] = insertelement <8 x i8> poison, i8 %a, i64 0

0 commit comments

Comments
 (0)