You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
[LNT] Sort machines by ID as expected by test case
Summary:
`tests/lnttool/admin.shtest` fails in some environments because it
expects the `list-machines` output in a certain order.
Assuming ascending order, the matching sort would be the one based on
the id. In particular, "localhost" follows "LNT" in both ASCII `strcmp`
and also with case-insensitive sorting, and the test expects "localhost"
first.
I'm open to doing the sorting on the client side, but this patch sorts
on the server side mainly to demonstrate that the expectation of the
test was unwarranted given the state of the code. Sorting on the server
side also benefits all clients, as opposed to just the ones that are
part of this package.
Reviewers: cmatthews, thopre, kristof.beyls
Reviewed By: cmatthews
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D67884
llvm-svn: 373129
0 commit comments