Remove unused key suffix in graphs.

As far as I can tell this suffix is completely unused, serving only to
distinguish request args with the same name. Flask already has the
ability to deal with such cases, so just do that instead.

Change-Id: I8e8b5514c2ece5b3e53d9b85b4d2476cab6d989f

Author: georges-arm

lnt/server/ui/templates/v4_graph.html

@@ -257,8 +257,9 @@
           </table>
 
           {# Add all the hidden fields. #}
-          {% for name,value in request.args.items() %}
-          {% if name.startswith('plot.') %}
+          {% for name,values in request.args.to_dict(flat=False).items() %}
+          {% for value in values %}
+          {% if name == 'plot' %}
           <input type="hidden" name="{{name}}" value="{{value}}"/>
           {% endif %}
           {% if name.startswith('baseline.') %}
@@ -268,6 +269,7 @@
           <input type="hidden" name="{{name}}" value="{{value}}"/>
           {% endif %}
           {% endfor %}
+          {% endfor %}
 
           <input class="btn btn-primary" style="clear: left; width: 100%"
                  type="submit" name="submit" value="Update" />

lnt/server/ui/templates/v4_run.html

@@ -33,7 +33,7 @@
 $('.profile-but-no-prev').tooltip();
 $('.profile-prev-only').tooltip();
 {% endblock %}
-  
+
 {% block title %}Run Results{% endblock %}
 
 {% macro get_cell_value(cr, field) %}
@@ -345,9 +345,9 @@ <h4>Parameters</h4>
         <tbody class="searchable">
           {% for test_name,test_id,cr in tests %}
             <tr>
-              <td><input type="checkbox" name="plot.{{test_id}}" value="{{machine.id}}.{{test_id}}.{{field_index}}"/></td>
+              <td><input type="checkbox" name="plot" value="{{machine.id}}.{{test_id}}.{{field_index}}"/></td>
               <td class="benchmark-name">
-                <a href="{{graph_base}}&amp;plot.{{test_id}}={{ machine.id}}.{{test_id}}.{{field_index}}">
+                <a href="{{graph_base}}&amp;plot={{machine.id}}.{{test_id}}.{{field_index}}">
                   {{ test_name }}
                 </a>
                 {{ utils.render_profile_link(cr.cur_profile, cr.prev_profile, run.id, compare_to.id, test_id) }}

lnt/server/ui/views.py

@@ -694,8 +694,7 @@ def v4_run_graph(id):
         abort(404, "Invalid run id {}".format(id))
 
     # Convert the old style test parameters encoding.
-    args = {'highlight_run': id}
-    plot_number = 0
+    args = {'highlight_run': id, 'plot': []}
     for name, value in request.args.items():
         # If this isn't a test specification, just forward it.
         if not name.startswith('test.'):
@@ -708,11 +707,10 @@ def v4_run_graph(id):
         #
         # into the new style of::
         #
-        #   plot.<number>=<machine id>.<test id>.<sample field index>
+        #   plot=<machine id>.<test id>.<sample field index>
         test_id = name.split('.', 1)[1]
-        args['plot.%d' % (plot_number,)] = '%d.%s.%s' % (
-            run.machine.id, test_id, value)
-        plot_number += 1
+        args['plot'].append('%d.%s.%s' % (
+            run.machine.id, test_id, value))
 
     return v4_redirect(v4_url_for(".v4_graph", **args))
 
@@ -750,7 +748,7 @@ def v4_graph_for_sample(sample_id, field_name):
     if field_index is None:
         abort(400, "Could not find field {}".format(field_name))
 
-    kwargs = {'plot.0': '{machine_id}.{test_id}.{field_index}'.format(
+    kwargs = {'plot': '{machine_id}.{test_id}.{field_index}'.format(
         machine_id=target_sample.run.machine.id,
         test_id=target_sample.test_id,
         field_index=field_index)}
@@ -1760,10 +1758,8 @@ def v4_matrix():
     """A table view for Run sample data, because *some* people really
     like to be able to see results textually.
     request.args.limit limits the number of samples.
-    for each dataset to add, there will be a "plot.n=.m.b.f" where m is machine
-    ID, b is benchmark ID and f os field kind offset. "n" is used to unique
-    the paramters, and is ignored.
-
+    for each dataset to add, there will be a "plot=.m.b.f" where m is machine
+    ID, b is benchmark ID and f os field kind offset.
     """
     session = request.session
     ts = request.get_testsuite()