Fix broken samples API (#74)

ldionne · web-flow · commit 2b61b2bbc184 · 2025-10-07T14:15:11.000-04:00
The samples API was performing an invalid SQL query since the ORM update in 5b02472. This fixes the problem and un-XFAILs the test.
diff --git a/lnt/server/ui/api.py b/lnt/server/ui/api.py
@@ -438,6 +438,7 @@ def get(machine_id, test_id, field_index):
 
         q = session.query(field.column, ts.Order.llvm_project_revision,
                           ts.Run.start_time, ts.Run.id) \
+            .select_from(ts.Sample) \
             .join(ts.Run) \
             .join(ts.Order) \
             .filter(ts.Run.machine_id == machine.id) \
diff --git a/tests/server/ui/test_api.py b/tests/server/ui/test_api.py
@@ -1,5 +1,3 @@
-# XFAIL: TODO-FIXME
-
 # Check that the LNT REST JSON API is working.
 # create temporary instance
 # RUN: rm -rf %t.instance

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# XFAIL: TODO-FIXME`
`2`		`-`
`3`	`1`	`# Check that the LNT REST JSON API is working.`
`4`	`2`	`# create temporary instance`
`5`	`3`	`# RUN: rm -rf %t.instance`