Skip to content

Commit 3a69408

Browse files
committed
Fix broken samples API
The samples API was performing an invalid SQL query since the ORM update in 5b02472. This fixes the problem and un-XFAILs the test.
1 parent 7d21dcd commit 3a69408

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

lnt/server/ui/api.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -438,6 +438,7 @@ def get(machine_id, test_id, field_index):
438438

439439
q = session.query(field.column, ts.Order.llvm_project_revision,
440440
ts.Run.start_time, ts.Run.id) \
441+
.select_from(ts.Sample) \
441442
.join(ts.Run) \
442443
.join(ts.Order) \
443444
.filter(ts.Run.machine_id == machine.id) \

tests/server/ui/test_api.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
# XFAIL: TODO-FIXME
2-
31
# Check that the LNT REST JSON API is working.
42
# create temporary instance
53
# RUN: rm -rf %t.instance

0 commit comments

Comments
 (0)