Skip to content

Commit 8a6a619

Browse files
committed
Make sure FCs and RI are flushed to the database before title rebuild
In some configurations the title rebuild would find no RIs. This should not be possible. Flush the newst RIs and FCs before title rebuild.
1 parent 4bb9f06 commit 8a6a619

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

lnt/server/db/fieldchange.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ def regenerate_fieldchanges_for_run(session, ts, run_id):
172172
test=test,
173173
field_id=field.id)
174174
session.add(f)
175+
session.flush()
175176
try:
176177
found, new_reg = identify_related_changes(session, ts,
177178
f, active_indicators)
@@ -258,6 +259,7 @@ def identify_related_changes(session, ts, fc, active_indicators):
258259
confidence))
259260
ri = ts.RegressionIndicator(regression, fc)
260261
session.add(ri)
262+
session.flush()
261263
active_indicators.append(ri)
262264
# Update the default title if needed.
263265
rebuild_title(session, ts, regression)

lnt/server/db/regression.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,8 +55,9 @@ def new_regression(session, ts, field_changes):
5555
ri1 = ts.RegressionIndicator(regression, fc)
5656
new_ris.append(ri1)
5757
session.add_all(new_ris)
58+
session.flush()
5859
rebuild_title(session, ts, regression)
59-
logger.info("Creating new Regression: {}".format(regression.title))
60+
logger.info("Creating new Regression: {} from {} RIs".format(regression.title, len(new_ris)))
6061
session.commit()
6162
return regression, new_ris
6263

0 commit comments

Comments
 (0)