[LNT] Fix sql index name collision

Summary:
As revealed by the exception printing failure prior to the previous
commit, sqllite throws an error when creating the index for the
RegressionID field for the NT and link testsuite schemas since they have
the same name. This commit adds the testsuite schema to the index name
to avoid this collision.

Reviewers: cmatthews, hubert.reinterpretcast, kristof.beyls, leandron, PrzemekWirkus

Reviewed By: PrzemekWirkus

Subscribers: arphaman, llvm-commits

Differential Revision: https://reviews.llvm.org/D68799

Author: Thomas Preud'homme

lnt/server/db/migrations/upgrade_15_to_16.py

@@ -11,7 +11,7 @@
 def _mk_index_on(engine, ts_name):
     fc_table = introspect_table(engine, "{}_FieldChangeV2".format(ts_name))
 
-    fast_fc_lookup = Index('idx_fast_fieldchange_lookup', fc_table.c.StartOrderID)
+    fast_fc_lookup = Index('{}_idx_fast_fieldchange_lookup'.format(ts_name), fc_table.c.StartOrderID)
     try:
         fast_fc_lookup.create(engine)
     except (sqlalchemy.exc.OperationalError, sqlalchemy.exc.ProgrammingError) as e:

lnt/server/db/migrations/upgrade_16_to_17.py

@@ -11,7 +11,7 @@
 def _mk_index_on(engine, ts_name):
     fc_table = introspect_table(engine, "{}_RegressionIndicator".format(ts_name))
 
-    fast_fc_lookup = Index('idx_fast_ri_lookup', fc_table.c.RegressionID)
+    fast_fc_lookup = Index('{}_idx_fast_ri_lookup'.format(ts_name), fc_table.c.RegressionID)
     try:
         fast_fc_lookup.create(engine)
     except (sqlalchemy.exc.OperationalError, sqlalchemy.exc.ProgrammingError) as e: