Skip to content

Commit c20e14e

Browse files
author
Thomas Preud'homme
committed
[LNT] Python 3 support: remove useless var-setting getter
Both the ComparisonResult constructor and the stddev_mean getter set the readonly stddev_mean. While Python 2 accepts it, Python 3 throws errors (cannot set attribute and infinite recursion respectively). Since that attribute does not appear to be used anywhere, this commit removes all this code. Reviewers: cmatthews, hubert.reinterpretcast, kristof.beyls Reviewed By: hubert.reinterpretcast Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D67882 llvm-svn: 374302
1 parent eba9b6d commit c20e14e

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

lnt/server/reporting/analysis.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,6 @@ def __init__(self, aggregation_fn,
9696
self.stddev = None
9797
self.MAD = None
9898

99-
self.stddev_mean = None # Only calculate this if needed.
10099
self.failed = cur_failed
101100
self.prev_failed = prev_failed
102101
self.samples = samples
@@ -105,14 +104,6 @@ def __init__(self, aggregation_fn,
105104
self.confidence_lv = confidence_lv
106105
self.bigger_is_better = bigger_is_better
107106

108-
@property
109-
def stddev_mean(self):
110-
"""The mean around stddev for current sampples. Cached after first call.
111-
"""
112-
if not self.stddev_mean:
113-
self.stddev_mean = stats.mean(self.samples)
114-
return self.stddev_mean
115-
116107
def __repr__(self):
117108
"""Print this ComparisonResult's constructor.
118109

0 commit comments

Comments
 (0)