Skip to content

Commit c92b04d

Browse files
committed
Fix a few obsolete uses of Flask-WTF forms
It seems that in a recent version, Flask-WTF's forms stopped providing the hidden_tag() method. Instead, FlaskForms provide that method.
1 parent 150dae4 commit c92b04d

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

lnt/server/ui/regression_views.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
from flask import render_template
77
from flask import request
88
from flask import flash
9+
import flask_wtf
910
from sqlalchemy import desc
1011
from sqlalchemy.orm.exc import NoResultFound
1112
from wtforms import SelectMultipleField, StringField, widgets, SelectField
1213
from wtforms import HiddenField
13-
from flask_wtf import Form
1414
from wtforms.validators import DataRequired
1515

1616
from lnt.server.ui.decorators import v4_route
@@ -39,7 +39,7 @@ class MultiCheckboxField(SelectMultipleField):
3939
option_widget = widgets.CheckboxInput()
4040

4141

42-
class TriagePageSelectedForm(Form):
42+
class TriagePageSelectedForm(flask_wtf.FlaskForm):
4343
field_changes = MultiCheckboxField("Changes", coerce=int)
4444
name = StringField('name', validators=[DataRequired()])
4545

@@ -125,7 +125,7 @@ def calc_impact(session, ts, fcs):
125125
return PrecomputedCR(1, 1, True)
126126

127127

128-
class MergeRegressionForm(Form):
128+
class MergeRegressionForm(flask_wtf.FlaskForm):
129129
regression_checkboxes = MultiCheckboxField("regression_checkboxes",
130130
coerce=int)
131131

@@ -251,7 +251,7 @@ def _get_regressions_from_selected_form(session, form, ts):
251251
return reg_inds, regressions
252252

253253

254-
class EditRegressionForm(Form):
254+
class EditRegressionForm(flask_wtf.FlaskForm):
255255
title = StringField(u'Title', validators=[DataRequired()])
256256
bug = StringField(u'Bug', validators=[DataRequired()])
257257
field_changes = MultiCheckboxField("Changes", coerce=int)

lnt/server/ui/views.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
from io import BytesIO
1010

1111
import flask
12+
import flask_wtf
1213
import sqlalchemy.sql
1314
from flask import abort
1415
from flask import current_app
@@ -18,7 +19,6 @@
1819
from flask import render_template
1920
from flask import request, url_for
2021
from flask import send_file
21-
from flask_wtf import Form
2222
from sqlalchemy.orm import joinedload
2323
from sqlalchemy.orm.exc import NoResultFound
2424
from wtforms import SelectField, StringField, SubmitField
@@ -584,7 +584,7 @@ def v4_run(id):
584584
return render_template("v4_run.html", **data)
585585

586586

587-
class PromoteOrderToBaseline(Form):
587+
class PromoteOrderToBaseline(flask_wtf.FlaskForm):
588588
name = StringField('Name', validators=[DataRequired(), Length(max=32)])
589589
description = StringField('Description', validators=[Length(max=256)])
590590
promote = SubmitField('Promote')
@@ -1845,7 +1845,7 @@ def v4_search():
18451845
]
18461846

18471847

1848-
class MatrixOptions(Form):
1848+
class MatrixOptions(flask_wtf.FlaskForm):
18491849
limit = SelectField('Size', choices=MATRIX_LIMITS)
18501850

18511851

0 commit comments

Comments
 (0)