Correct result table access in async daily report

Result table is indexed by the field's name, not display_name. Adjust
the async report accordingly.

Change-Id: Id7f4dbb07a1619a62fa2a611afce277cafe33815

Author: AymenQ

lnt/server/ui/templates/reporting/daily_report_async.html

@@ -120,7 +120,7 @@ <h3>Result Table ({{ field.display_name }})</h3>
       <th style="{{ styles.th }}">Sparkline</th>
     </tr>
   </thead>
-<tbody id="rt-{{ field.display_name }}">
+<tbody id="rt-{{ field.name }}">
 </tbody></table>
 {%- endfor -%}
 {% endif %}
@@ -285,6 +285,7 @@ <h3>Result Table ({{ field.display_name }})</h3>
 const FIELDS = [
 {% for field in report.fields|reverse %}
   {
+    name: "{{ field.name }}",
     display_name: "{{ field.display_name }}",
     index: "{{ report.ts.get_field_index(field) }}"
   },
@@ -295,7 +296,7 @@ <h3>Result Table ({{ field.display_name }})</h3>
 // we cannot just append to the DOM directly since we want the result table
 // to be sorted by some priority metric (largest abs percentage delta).
 var KEY_RUNS = {}; // { machine.id -> run.id }
-var RESULTS = {}; // { field.display_name -> { test.id -> { name, results: { machine.id -> day results }}}}
+var RESULTS = {}; // { field.name -> { test.id -> { name, results: { machine.id -> day results }}}}
 
 function test_priority_compare(a, b) {
   const a_res = a[1].results;
@@ -313,7 +314,7 @@ <h3>Result Table ({{ field.display_name }})</h3>
 }
 
 function regenerate_results_tables_for_field(field, results) {
-  var rt_table_id = "rt-" + field.display_name;
+  var rt_table_id = "rt-" + field.name;
   var rt_table = document.getElementById(rt_table_id);
   rt_table.innerHTML = '';
   for (const [rt_test_id, rt_value] of Object.entries(results).sort(test_priority_compare)) {
@@ -362,7 +363,7 @@ <h3>Result Table ({{ field.display_name }})</h3>
 
 function regenerate_results_tables() {
   for (const field of FIELDS) {
-    regenerate_results_tables_for_field(field, RESULTS[field.display_name]);
+    regenerate_results_tables_for_field(field, RESULTS[field.name]);
   }
 }
 
@@ -408,12 +409,12 @@ <h3>Result Table ({{ field.display_name }})</h3>
     var today_key_run = res.data.machine_runs['' + machine.id]["0"];
     if (today_key_run) {
       KEY_RUNS[machine.id] = today_key_run.id;
-      // RESULTS: { field.display_name -> { test.id -> { name, results: { machine.id -> day results }}}}
+      // RESULTS: { field.name -> { test.id -> { name, results: { machine.id -> day results }}}}
       for (const field of FIELDS) {
-        RESULTS[field.display_name] = RESULTS[field.display_name] || {};
-        var field_results = RESULTS[field.display_name];
+        RESULTS[field.name] = RESULTS[field.name] || {};
+        var field_results = RESULTS[field.name];
         // merge new data into (possibly pre-existing from other results) field_results object.
-        var rt_data = res.data['result_table'][field.display_name]
+        var rt_data = res.data['result_table'][field.name]
         if (rt_data) {
           for (const [rt_test_id, rt_value] of Object.entries(rt_data)) {
             var rt_test_name = res.data.reporting_tests['' + rt_test_id].name;