Skip to content

Commit f5d76a0

Browse files
apolyakovHubert Tong
authored andcommitted
Fixes a bug in pstat module
Summary: There was a bug in the pstat module: LNT crashes with "UnboundLocalError: local variable 'list' referenced before assignment" when trying to add linear regression to the regression graph. Reviewers: cmatthews, leandron, hubert.reinterpretcast Reviewed By: cmatthews Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D74593
1 parent e630ecf commit f5d76a0

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

lnt/external/stats/pstat.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -182,22 +182,22 @@ def simpleabut (source, addon):
182182
if not isinstance(addon, (list, tuple)):
183183
addon = [addon]
184184
minlen = min(len(source), len(addon))
185-
list = copy.deepcopy(source) # start abut process
185+
source_copy = copy.deepcopy(source) # start abut process
186186
if not isinstance(source[0], (list, tuple)):
187187
if not isinstance(addon[0], (list, tuple)):
188188
for i in range(minlen):
189-
list[i] = [source[i]] + [addon[i]] # source/addon = column
189+
source_copy[i] = [source[i]] + [addon[i]] # source/addon = column
190190
else:
191191
for i in range(minlen):
192-
list[i] = [source[i]] + addon[i] # addon=list-of-lists
192+
source_copy[i] = [source[i]] + addon[i] # addon=list-of-lists
193193
else:
194194
if not isinstance(addon[0], (list, tuple)):
195195
for i in range(minlen):
196-
list[i] = source[i] + [addon[i]] # source=list-of-lists
196+
source_copy[i] = source[i] + [addon[i]] # source=list-of-lists
197197
else:
198198
for i in range(minlen):
199-
list[i] = source[i] + addon[i] # source/addon = list-of-lists
200-
source = list
199+
source_copy[i] = source[i] + addon[i] # source/addon = list-of-lists
200+
source = source_copy
201201
return source
202202

203203

0 commit comments

Comments
 (0)