Fix various Flake8 issues in the codebase

lnt/server/db/migrations/upgrade_2_to_3.py

@@ -46,7 +46,7 @@ def upgrade_testsuite(engine, session, name):
     # Grab Test Suite.
     test_suite = session.query(upgrade_0_to_1.TestSuite).\
                  filter_by(name=name).first()
-    assert(test_suite is not None)
+    assert test_suite is not None
 
     # Add FieldChange to the test suite.
     Base = add_fieldchange(test_suite)

lnt/server/db/migrations/upgrade_7_to_8.py

@@ -87,7 +87,7 @@ def upgrade_testsuite(engine, session, name):
     # Grab Test Suite.
     test_suite = session.query(upgrade_0_to_1.TestSuite).\
                  filter_by(name=name).first()
-    assert(test_suite is not None)
+    assert test_suite is not None
 
     # Add FieldChange to the test suite.
     Base = add_regressions(test_suite)

lnt/server/db/testsuite.py

@@ -167,7 +167,7 @@ def from_json(data):
                 run_fields.append(field)
         ts.run_fields = run_fields
         ts.order_fields = order_fields
-        assert(len(order_fields) > 0)
+        assert len(order_fields) > 0
 
         sample_fields = []
         for index, metric_desc in enumerate(data['metrics']):

lnt/server/ui/util.py

@@ -279,7 +279,7 @@ def convert_revision(dotted, cache=None):
             return val
 
     dotted_parsed = integral_rex.findall(dotted)
-    val = tuple([int(d) for d in dotted_parsed] or 
+    val = tuple([int(d) for d in dotted_parsed] or
                 [int(hashlib.sha1(dotted.encode("utf-8")).hexdigest(), 16)])
     if cache is not None:
         cache[dotted] = val

lnt/testing/__init__.py

@@ -532,7 +532,7 @@ def upgrade_1_to_2(data, ts_name):
     result['format_version'] = '2'
     report_version = data['Run']['Info'].pop('__report_version__', '1')
     # We should not be in upgrade_1_to_2 for other versions
-    assert(report_version == '1')
+    assert report_version == '1'
     tag = data['Run']['Info'].pop('tag', None)
     if tag is not None and tag != ts_name:
         raise ValueError("Importing '%s' data into '%s' testsuite" %
@@ -589,7 +589,7 @@ def upgrade_1_to_2(data, ts_name):
 
         found_metric = False
         for oldname, newname in upgrade.metric_rename.items():
-            assert(oldname.startswith('.'))
+            assert oldname.startswith('.')
             if name_metric.endswith(oldname):
                 name = name_metric[:-len(oldname)]
                 metric = newname

tests/SharedInputs/FakeCompilers/fakecompiler.py

@@ -178,6 +178,7 @@ def print_verbose_info(self):
  "%s" "-cc1" "-E" ... more boring stuff here ...""" % (
             g_program,), file=sys.stderr)
 
+
 class GCCDebian(FakeCompiler):
     compiler_name = "gcc-debian"
 
@@ -189,6 +190,7 @@ def print_verbose_info(self):
     def print_dumpmachine(self):
         print("x86_64-linux-gnu")
 
+
 class GCCTrunk(FakeCompiler):
     compiler_name = "gcc-trunk"