From 388c0a7c2add5f385198ae7e087843bff2bffa61 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Tue, 7 Oct 2025 11:05:06 -0400 Subject: [PATCH] Unpin versions in setup.py (2nd attempt) This patch unpins versions in setup.py since they are pinned in requirements.txt. This is effectively a revert of 11c2d9ebe99d and 8fc27f472. When we originally unpinned versions from setup.py, some clients were running `setup.py` directly to install `lnt`, which means they started fetching untested and incompatible versions of packages. Since then, we've documented the new installation procedure based on pip and our pinned requirements (in #70). --- setup.py | 36 +++++++++++++----------------------- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/setup.py b/setup.py index a5825385..a8caf6c9 100644 --- a/setup.py +++ b/setup.py @@ -14,13 +14,6 @@ os.environ["CXX"] = "xcrun --sdk macosx clang" cflags += ['-stdlib=libc++', '-mmacosx-version-min=10.7'] -# TODO: Remove this once we assume that setup.py isn't called directly to install lnt -# setuptools expects to be invoked from within the directory of setup.py, but -# it is nice to allow: -# python path/to/setup.py install -# to work (for scripts, etc.) -os.chdir(os.path.dirname(os.path.abspath(__file__))) - cPerf = Extension('lnt.testing.profile.cPerf', sources=['lnt/testing/profile/cPerf.cpp'], extra_compile_args=['-std=c++11'] + cflags) @@ -116,24 +109,21 @@ ], }, install_requires=[ - "six", - "aniso8601==1.2.0", - "Flask==0.12.2", - "Flask-RESTful==0.3.4", - "Jinja2==2.11.3", - "MarkupSafe==1.1.1", - "SQLAlchemy==1.3.24", - "Werkzeug==0.15.6", - "itsdangerous==0.24", - "python-gnupg==0.3.7", - "pytz==2016.10", + "aniso8601", + "certifi", + "click", + "Flask-RESTful", + "Flask-WTF", + "Flask", + "Jinja2", + "MarkupSafe", + "python-gnupg", "pyyaml", - "WTForms==2.0.2", - "Flask-WTF==0.12", - "typing", - "click==6.7", "requests", - "certifi" + "SQLAlchemy", + "typing", + "Werkzeug", + "WTForms", ], ext_modules=[cPerf],