Fix several tests failing due to missing CMAKE_OBJDUMP in CMake test fixture #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fixture In llvm#37, test_suite.py started requiring the CMAKE_OBJDUMP variable from the set of CMake variables. Various tests were using a fake CMake test fixture which defines various CMake variables, however CMAKE_OBJDUMP wasn't added in llvm#47, breaking a bunch of tests. This was probably never noticed because the tests were completely broken back then, I assume they were not being run on a regular basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #37, test_suite.py started requiring the CMAKE_OBJDUMP variable from the set of CMake variables. Various tests were using a fake CMake test fixture which defines various CMake variables, however CMAKE_OBJDUMP wasn't added in #47, breaking a bunch of tests.
This was probably never noticed because the tests were completely broken back then, I assume they were not being run on a regular basis.