Skip to content

Commit 00627a4

Browse files
committed
review: clean up test cases
- makes key value spacing uniform and minimal of yaml objects - simplify the tests by using --implicit-check-not and CHECK-NEXT for the valid parts
1 parent f3ce155 commit 00627a4

File tree

3 files changed

+49
-57
lines changed

3 files changed

+49
-57
lines changed

llvm/test/tools/llvm-objcopy/DXContainer/extract-section-basic.test

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
# RUN: yaml2obj %s -o %t
55
# RUN: llvm-objcopy %t --extract-section=RTS0=%t.rts0.out
6-
# RUN: obj2yaml %t.rts0.out | FileCheck %s
6+
# RUN: obj2yaml %t.rts0.out | FileCheck %s --implicit-check-not=Name:
77

88
## The DXContainer described below was generated with:
99

@@ -27,8 +27,7 @@
2727
# CHECK-NEXT: PartCount: 1
2828
# CHECK-NEXT: PartOffsets: [ 36 ]
2929
# CHECK-NEXT: Parts:
30-
# CHECK-NOT: - Name: {{DXIL|SFI0|HASH|ISG1|OSG1|PSV0}}
31-
# CHECK: Name: RTS0
30+
# CHECK-NEXT: Name: RTS0
3231
# CHECK-NEXT Size: 24
3332
# CHECK-NEXT RootSignature:
3433
# CHECK-NEXT Version: 2
@@ -37,7 +36,6 @@
3736
# CHECK-NEXT NumStaticSamplers: 0
3837
# CHECK-NEXT StaticSamplersOffset: 24
3938
# CHECK-NEXT Parameters: []
40-
# CHECK-NOT: - Name: {{DXIL|SFI0|HASH|ISG1|OSG1|PSV0}}
4139

4240
--- !dxcontainer
4341
Header:

llvm/test/tools/llvm-objcopy/DXContainer/extract-section-errs.test

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@
99

1010
--- !dxcontainer
1111
Header:
12-
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
13-
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
12+
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
13+
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
1414
Version:
15-
Major: 1
16-
Minor: 0
17-
PartCount: 1
15+
Major: 1
16+
Minor: 0
17+
PartCount: 1
1818
Parts:
19-
- Name: FKE0
20-
Size: 8
19+
- Name: FKE0
20+
Size: 8
2121
...
2222

2323
## We can't extract a part that is specified incorrectly.
@@ -28,13 +28,13 @@ Parts:
2828

2929
--- !dxcontainer
3030
Header:
31-
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
32-
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
31+
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
32+
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
3333
Version:
34-
Major: 1
35-
Minor: 0
36-
PartCount: 1
34+
Major: 1
35+
Minor: 0
36+
PartCount: 1
3737
Parts:
38-
- Name: FKE0
39-
Size: 8
38+
- Name: FKE0
39+
Size: 8
4040
...

llvm/test/tools/llvm-objcopy/DXContainer/extract-section-headers.test

Lines changed: 33 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -3,57 +3,51 @@
33

44
# RUN: yaml2obj %s -o %t
55
# RUN: llvm-objcopy %t --extract-section=FKE1=%t.fke1.out --extract-section=FKE4=%t.fke4.out
6-
# RUN: obj2yaml %t.fke1.out | FileCheck %s --check-prefixes=CHECK,FKE1
7-
# RUN: obj2yaml %t.fke4.out | FileCheck %s --check-prefixes=CHECK,FKE4
6+
# RUN: obj2yaml %t.fke1.out | FileCheck %s --check-prefixes=CHECK,FKE1 --implicit-check-not=Name:
7+
# RUN: obj2yaml %t.fke4.out | FileCheck %s --check-prefixes=CHECK,FKE4 --implicit-check-not=Name:
88

99
# FKE1: FileSize: 52
1010
# FKE4: FileSize: 1732
1111
# CHECK-NEXT: PartCount: 1
1212
# CHECK-NEXT: PartOffsets: [ 36 ]
1313
# CHECK-NEXT: Parts:
14-
15-
# CHECK-NOT: FKE0
16-
# FKE1: Name: FKE1
17-
# FKE4-NOT: FKE1
18-
# CHECK-NOT: FKE2
19-
# CHECK-NOT: FKE3
20-
# FKE1-NOT: FKE4
21-
# FKE4: Name: FKE4
22-
# CHECK-NOT: FKE5
23-
# CHECK-NOT: DXIL
14+
# FKE1-NEXT: Name: FKE1
15+
# FKE1-NEXT: Size: 8
16+
# FKE4-NEXT: Name: FKE4
17+
# FKE4-NEXT: Size: 1688
2418

2519
--- !dxcontainer
2620
Header:
27-
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
28-
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
21+
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
22+
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
2923
Version:
30-
Major: 1
31-
Minor: 0
32-
FileSize: 1996
33-
PartCount: 7
34-
PartOffsets: [ 60, 76, 92, 108, 236, 1932, 1960 ]
24+
Major: 1
25+
Minor: 0
26+
FileSize: 1996
27+
PartCount: 7
28+
PartOffsets: [ 60, 76, 92, 108, 236, 1932, 1960 ]
3529
Parts:
36-
- Name: FKE0
37-
Size: 8
38-
- Name: FKE1
39-
Size: 8
40-
- Name: FKE2
41-
Size: 8
42-
- Name: FKE3
43-
Size: 120
44-
- Name: FKE4
45-
Size: 1688
46-
- Name: FKE5
47-
Size: 20
48-
- Name: DXIL
49-
Size: 28
30+
- Name: FKE0
31+
Size: 8
32+
- Name: FKE1
33+
Size: 8
34+
- Name: FKE2
35+
Size: 8
36+
- Name: FKE3
37+
Size: 120
38+
- Name: FKE4
39+
Size: 1688
40+
- Name: FKE5
41+
Size: 20
42+
- Name: DXIL
43+
Size: 28
5044
Program:
51-
MajorVersion: 6
52-
MinorVersion: 5
53-
ShaderKind: 5
54-
Size: 8
45+
MajorVersion: 6
46+
MinorVersion: 5
47+
ShaderKind: 5
48+
Size: 8
5549
DXILMajorVersion: 1
5650
DXILMinorVersion: 5
57-
DXILSize: 4
58-
DXIL: [ 0x42, 0x43, 0xC0, 0xDE, ]
51+
DXILSize: 4
52+
DXIL: [ 0x42, 0x43, 0xC0, 0xDE, ]
5953
...

0 commit comments

Comments
 (0)