address comments

Author: V-FEXrt

llvm/include/llvm/Analysis/DXILResource.h

@@ -448,11 +448,11 @@ class DXILBindingMap {
 
   /// Resolves a resource handle into a vector of ResourceBindingInfos that
   /// represent the possible unique creations of the handle. Certain cases are
-  /// ambiguous so mulitple creation instructions may be returned. The resulting
+  /// ambiguous so multiple creation instructions may be returned. The resulting
   /// ResourceBindingInfo can be used to depuplicate unique handles that
   /// reference the same resource
   SmallVector<dxil::ResourceBindingInfo>
-  findCreationInfo(const Value *Key) const;
+  findByUse(const Value *Key) const;
 
   const_iterator find(const CallInst *Key) const {
     auto Pos = CallMap.find(Key);

llvm/lib/Analysis/DXILResource.cpp

@@ -771,11 +771,11 @@ void DXILBindingMap::print(raw_ostream &OS, DXILResourceTypeMap &DRTM,
 }
 
 SmallVector<dxil::ResourceBindingInfo>
-DXILBindingMap::findCreationInfo(const Value *Key) const {
+DXILBindingMap::findByUse(const Value *Key) const {
   if (const PHINode *Phi = dyn_cast<PHINode>(Key)) {
     SmallVector<dxil::ResourceBindingInfo> Children;
     for (const Value *V : Phi->operands()) {
-      Children.append(findCreationInfo(V));
+      Children.append(findByUse(V));
     }
     return Children;
   }
@@ -803,7 +803,7 @@ DXILBindingMap::findCreationInfo(const Value *Key) const {
     if (V->getType() != UseType)
       continue;
 
-    Children.append(findCreationInfo(V));
+    Children.append(findByUse(V));
   }
 
   return Children;

llvm/unittests/Target/DirectX/UniqueResourceFromUseTests.cpp

@@ -73,7 +73,7 @@ declare void @a.func(target("dx.RawBuffer", float, 1, 0) %handle)
     for (const User *U : F.users()) {
       const CallInst *CI = cast<CallInst>(U);
       const Value *Handle = CI->getArgOperand(0);
-      const auto Bindings = DBM.findCreationInfo(Handle);
+      const auto Bindings = DBM.findByUse(Handle);
       ASSERT_EQ(Bindings.size(), 1u)
           << "Handle should resolve into one resource";
 
@@ -123,7 +123,7 @@ declare target("dx.RawBuffer", float, 1, 0) @ind.func(target("dx.RawBuffer", flo
     for (const User *U : F.users()) {
       const CallInst *CI = cast<CallInst>(U);
       const Value *Handle = CI->getArgOperand(0);
-      const auto Bindings = DBM.findCreationInfo(Handle);
+      const auto Bindings = DBM.findByUse(Handle);
       ASSERT_EQ(Bindings.size(), 1u)
           << "Handle should resolve into one resource";
 
@@ -176,7 +176,7 @@ declare target("dx.RawBuffer", float, 1, 0) @ind.func(target("dx.RawBuffer", flo
     for (const User *U : F.users()) {
       const CallInst *CI = cast<CallInst>(U);
       const Value *Handle = CI->getArgOperand(0);
-      const auto Bindings = DBM.findCreationInfo(Handle);
+      const auto Bindings = DBM.findByUse(Handle);
       ASSERT_EQ(Bindings.size(), 4u)
           << "Handle should resolve into four resources";
 
@@ -256,7 +256,7 @@ declare target("dx.RawBuffer", float, 1, 0) @ind.func(target("dx.RawBuffer", flo
     for (const User *U : F.users()) {
       const CallInst *CI = cast<CallInst>(U);
       const Value *Handle = CI->getArgOperand(0);
-      const auto Bindings = DBM.findCreationInfo(Handle);
+      const auto Bindings = DBM.findByUse(Handle);
       ASSERT_EQ(Bindings.size(), 2u)
           << "Handle should resolve into four resources";