address comments

Author: Wolfram70

mlir/include/mlir/Dialect/LLVMIR/NVVMTraits.h

@@ -24,8 +24,15 @@ namespace NVVM {
 // Structure to store and check compatibility of SM versions.
 struct NVVMCheckSMVersion {
   int archVersion;
+  
+  // true if the SM version is accelerated (Ex. sm_90a vs sm_90)
   bool archAccelerated;
-  bool exactMatch;
+  
+  // true if the target SM version must exactly match this one
+  // (both archVersion and archAccelerated)
+  // Ex. sm_90a with exactMatch = false will also match with
+  // sm_100a, sm_120a, etc...
+  bool exactMatch; 
 
   NVVMCheckSMVersion()
       : archVersion(0), archAccelerated(false), exactMatch(false) {}

mlir/lib/Dialect/LLVMIR/IR/NVVMDialect.cpp

@@ -1738,14 +1738,16 @@ LogicalResult NVVMTargetAttr::verifyTarget(Operation *gpuModule) {
     return success();
 
   auto gpuModuleOp = llvm::dyn_cast<gpu::GPUModuleOp>(gpuModule);
-  if (!gpuModuleOp)
+  if (!gpuModuleOp) {
     return emitError(gpuModule->getLoc(),
                      "NVVM target attribute must be attached to a GPU module");
+  }
 
   NVVMCheckSMVersion targetSMVersion(getChip());
-  if (targetSMVersion.archVersion < 20)
+  if (targetSMVersion.archVersion < 20) {
     return emitError(gpuModule->getLoc(),
                      "Minimum NVVM target SM version is sm_20");
+  }
 
   gpuModuleOp->walk([&](Operation *op) {
     if (auto reqOp = llvm::dyn_cast<NVVM::RequiresSMInterface>(op)) {