Apply suggestions from code review

Co-authored-by: Jakub Kuderski <[email protected]>

Author: amd-eochoalo

mlir/lib/Conversion/VectorToSPIRV/VectorToSPIRV.cpp

@@ -751,7 +751,7 @@ struct VectorLoadOpConverter final
 
     auto memoryAccess = spirv::MemoryAccess::None;
     spirv::MemoryAccessAttr memoryAccessAttr;
-    IntegerAttr alignmentAttr = nullptr;
+    IntegerAttr alignmentAttr;
     if (alignment.has_value()) {
       memoryAccess = memoryAccess | spirv::MemoryAccess::Aligned;
       memoryAccessAttr =
@@ -820,7 +820,7 @@ struct VectorStoreOpConverter final
 
     auto memoryAccess = spirv::MemoryAccess::None;
     spirv::MemoryAccessAttr memoryAccessAttr;
-    IntegerAttr alignmentAttr = nullptr;
+    IntegerAttr alignmentAttr;
     if (alignment.has_value()) {
       memoryAccess = memoryAccess | spirv::MemoryAccess::Aligned;
       memoryAccessAttr =

mlir/test/Dialect/SPIRV/IR/invalid.mlir

@@ -29,7 +29,7 @@ func.func @aligned_load_non_power_of_two() -> () {
 func.func @aligned_store_non_positive(%arg0 : f32) -> () {
   %0 = spirv.Variable : !spirv.ptr<f32, Function>
   // expected-error@below {{'spirv.Store' op attribute 'alignment' failed to satisfy constraint: 32-bit signless integer attribute whose value is positive and whose value is a power of two > 0}}
-  spirv.Store  "Function" %0, %arg0 ["Aligned", 0] : f32
+  spirv.Store "Function" %0, %arg0 ["Aligned", 0] : f32
   return
 }
 
@@ -38,6 +38,6 @@ func.func @aligned_store_non_positive(%arg0 : f32) -> () {
 func.func @aligned_store_non_power_of_two(%arg0 : f32) -> () {
   %0 = spirv.Variable : !spirv.ptr<f32, Function>
   // expected-error@below {{'spirv.Store' op attribute 'alignment' failed to satisfy constraint: 32-bit signless integer attribute whose value is positive and whose value is a power of two > 0}}
-  spirv.Store  "Function" %0, %arg0 ["Aligned", 3] : f32
+  spirv.Store "Function" %0, %arg0 ["Aligned", 3] : f32
   return
 }