address comment

Author: broxigarchen

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp

@@ -3578,11 +3578,10 @@ SDValue AMDGPUTargetLowering::LowerFP_TO_FP16(SDValue Op, SelectionDAG &DAG) con
     return SDValue();
   }
 
-  return LowerF64ToF16(N0, Op.getValueType(), DL, DAG);
+  return LowerF64ToF16(N0, DL, DAG);
 }
 
-SDValue AMDGPUTargetLowering::LowerF64ToF16(SDValue Src, EVT ResTy,
-                                            const SDLoc &DL,
+SDValue AMDGPUTargetLowering::LowerF64ToF16(SDValue Src, const SDLoc &DL,
                                             SelectionDAG &DAG) const {
   assert(Src.getSimpleValueType() == MVT::f64);
 
@@ -3667,8 +3666,7 @@ SDValue AMDGPUTargetLowering::LowerF64ToF16(SDValue Src, EVT ResTy,
   Sign = DAG.getNode(ISD::AND, DL, MVT::i32, Sign,
                      DAG.getConstant(0x8000, DL, MVT::i32));
 
-  V = DAG.getNode(ISD::OR, DL, MVT::i32, Sign, V);
-  return DAG.getZExtOrTrunc(V, DL, ResTy);
+  return DAG.getNode(ISD::OR, DL, MVT::i32, Sign, V);
 }
 
 SDValue AMDGPUTargetLowering::LowerFP_TO_INT(const SDValue Op,

llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h

@@ -97,8 +97,7 @@ class AMDGPUTargetLowering : public TargetLowering {
   SDValue LowerFP_TO_FP16(SDValue Op, SelectionDAG &DAG) const;
   SDValue LowerFP_TO_INT(SDValue Op, SelectionDAG &DAG) const;
 
-  SDValue LowerF64ToF16(SDValue Src, EVT ResTy, const SDLoc &DL,
-                        SelectionDAG &DAG) const;
+  SDValue LowerF64ToF16(SDValue Src, const SDLoc &DL, SelectionDAG &DAG) const;
 
   SDValue LowerSIGN_EXTEND_INREG(SDValue Op, SelectionDAG &DAG) const;
 

llvm/lib/Target/AMDGPU/SIISelLowering.cpp

@@ -6905,8 +6905,9 @@ SDValue SITargetLowering::lowerFP_ROUND(SDValue Op, SelectionDAG &DAG) const {
         SDValue Src32 = DAG.getNode(ISD::FP_ROUND, DL, MVT::f32, Src, Flags);
         return DAG.getNode(ISD::FP_ROUND, DL, MVT::f16, Src32, Flags);
       } else {
-        SDValue FpToFp16 = LowerF64ToF16(Src, MVT::i16, DL, DAG);
-        return DAG.getNode(ISD::BITCAST, DL, MVT::f16, FpToFp16);
+        SDValue FpToFp16 = LowerF64ToF16(Src, DL, DAG);
+        SDValue Trunc = DAG.getNode(ISD::TRUNCATE, DL, MVT::i16, FpToFp16);
+        return DAG.getNode(ISD::BITCAST, DL, MVT::f16, Trunc);
       }
     } else {
       SDValue FpToFp16 = DAG.getNode(ISD::FP_TO_FP16, DL, MVT::i32, Src);