Skip to content

Commit 01fca01

Browse files
authored
[mlir][spirv] Simplify inheriting constructor declarations. NFC. (#159681)
Use the `Base` type alias from #158433.
1 parent 116ca95 commit 01fca01

File tree

17 files changed

+111
-111
lines changed

17 files changed

+111
-111
lines changed

mlir/lib/Conversion/ArithToSPIRV/ArithToSPIRV.cpp

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ struct ElementwiseArithOpPattern final : OpConversionPattern<Op> {
232232
/// Converts composite arith.constant operation to spirv.Constant.
233233
struct ConstantCompositeOpPattern final
234234
: public OpConversionPattern<arith::ConstantOp> {
235-
using OpConversionPattern::OpConversionPattern;
235+
using Base::Base;
236236

237237
LogicalResult
238238
matchAndRewrite(arith::ConstantOp constOp, OpAdaptor adaptor,
@@ -357,7 +357,7 @@ struct ConstantCompositeOpPattern final
357357
/// Converts scalar arith.constant operation to spirv.Constant.
358358
struct ConstantScalarOpPattern final
359359
: public OpConversionPattern<arith::ConstantOp> {
360-
using OpConversionPattern::OpConversionPattern;
360+
using Base::Base;
361361

362362
LogicalResult
363363
matchAndRewrite(arith::ConstantOp constOp, OpAdaptor adaptor,
@@ -467,7 +467,7 @@ static Value emulateSignedRemainder(Location loc, Value lhs, Value rhs,
467467
/// This cannot be merged into the template unary/binary pattern due to Vulkan
468468
/// restrictions over spirv.SRem and spirv.SMod.
469469
struct RemSIOpGLPattern final : public OpConversionPattern<arith::RemSIOp> {
470-
using OpConversionPattern::OpConversionPattern;
470+
using Base::Base;
471471

472472
LogicalResult
473473
matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor,
@@ -483,7 +483,7 @@ struct RemSIOpGLPattern final : public OpConversionPattern<arith::RemSIOp> {
483483

484484
/// Converts arith.remsi to OpenCL SPIR-V ops.
485485
struct RemSIOpCLPattern final : public OpConversionPattern<arith::RemSIOp> {
486-
using OpConversionPattern::OpConversionPattern;
486+
using Base::Base;
487487

488488
LogicalResult
489489
matchAndRewrite(arith::RemSIOp op, OpAdaptor adaptor,
@@ -534,7 +534,7 @@ struct BitwiseOpPattern final : public OpConversionPattern<Op> {
534534

535535
/// Converts arith.xori to SPIR-V operations.
536536
struct XOrIOpLogicalPattern final : public OpConversionPattern<arith::XOrIOp> {
537-
using OpConversionPattern::OpConversionPattern;
537+
using Base::Base;
538538

539539
LogicalResult
540540
matchAndRewrite(arith::XOrIOp op, OpAdaptor adaptor,
@@ -558,7 +558,7 @@ struct XOrIOpLogicalPattern final : public OpConversionPattern<arith::XOrIOp> {
558558
/// Converts arith.xori to SPIR-V operations if the type of source is i1 or
559559
/// vector of i1.
560560
struct XOrIOpBooleanPattern final : public OpConversionPattern<arith::XOrIOp> {
561-
using OpConversionPattern::OpConversionPattern;
561+
using Base::Base;
562562

563563
LogicalResult
564564
matchAndRewrite(arith::XOrIOp op, OpAdaptor adaptor,
@@ -585,7 +585,7 @@ struct XOrIOpBooleanPattern final : public OpConversionPattern<arith::XOrIOp> {
585585
/// Converts arith.uitofp to spirv.Select if the type of source is i1 or vector
586586
/// of i1.
587587
struct UIToFPI1Pattern final : public OpConversionPattern<arith::UIToFPOp> {
588-
using OpConversionPattern::OpConversionPattern;
588+
using Base::Base;
589589

590590
LogicalResult
591591
matchAndRewrite(arith::UIToFPOp op, OpAdaptor adaptor,
@@ -614,7 +614,7 @@ struct UIToFPI1Pattern final : public OpConversionPattern<arith::UIToFPOp> {
614614
/// Converts arith.index_cast to spirv.INotEqual if the target type is i1.
615615
struct IndexCastIndexI1Pattern final
616616
: public OpConversionPattern<arith::IndexCastOp> {
617-
using OpConversionPattern::OpConversionPattern;
617+
using Base::Base;
618618

619619
LogicalResult
620620
matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor,
@@ -638,7 +638,7 @@ struct IndexCastIndexI1Pattern final
638638
/// Converts arith.index_cast to spirv.Select if the source type is i1.
639639
struct IndexCastI1IndexPattern final
640640
: public OpConversionPattern<arith::IndexCastOp> {
641-
using OpConversionPattern::OpConversionPattern;
641+
using Base::Base;
642642

643643
LogicalResult
644644
matchAndRewrite(arith::IndexCastOp op, OpAdaptor adaptor,
@@ -666,7 +666,7 @@ struct IndexCastI1IndexPattern final
666666
/// Converts arith.extsi to spirv.Select if the type of source is i1 or vector
667667
/// of i1.
668668
struct ExtSII1Pattern final : public OpConversionPattern<arith::ExtSIOp> {
669-
using OpConversionPattern::OpConversionPattern;
669+
using Base::Base;
670670

671671
LogicalResult
672672
matchAndRewrite(arith::ExtSIOp op, OpAdaptor adaptor,
@@ -707,7 +707,7 @@ struct ExtSII1Pattern final : public OpConversionPattern<arith::ExtSIOp> {
707707
/// Converts arith.extsi to spirv.Select if the type of source is neither i1 nor
708708
/// vector of i1.
709709
struct ExtSIPattern final : public OpConversionPattern<arith::ExtSIOp> {
710-
using OpConversionPattern::OpConversionPattern;
710+
using Base::Base;
711711

712712
LogicalResult
713713
matchAndRewrite(arith::ExtSIOp op, OpAdaptor adaptor,
@@ -758,7 +758,7 @@ struct ExtSIPattern final : public OpConversionPattern<arith::ExtSIOp> {
758758
/// Converts arith.extui to spirv.Select if the type of source is i1 or vector
759759
/// of i1.
760760
struct ExtUII1Pattern final : public OpConversionPattern<arith::ExtUIOp> {
761-
using OpConversionPattern::OpConversionPattern;
761+
using Base::Base;
762762

763763
LogicalResult
764764
matchAndRewrite(arith::ExtUIOp op, OpAdaptor adaptor,
@@ -783,7 +783,7 @@ struct ExtUII1Pattern final : public OpConversionPattern<arith::ExtUIOp> {
783783
/// Converts arith.extui for cases where the type of source is neither i1 nor
784784
/// vector of i1.
785785
struct ExtUIPattern final : public OpConversionPattern<arith::ExtUIOp> {
786-
using OpConversionPattern::OpConversionPattern;
786+
using Base::Base;
787787

788788
LogicalResult
789789
matchAndRewrite(arith::ExtUIOp op, OpAdaptor adaptor,
@@ -823,7 +823,7 @@ struct ExtUIPattern final : public OpConversionPattern<arith::ExtUIOp> {
823823
/// Converts arith.trunci to spirv.Select if the type of result is i1 or vector
824824
/// of i1.
825825
struct TruncII1Pattern final : public OpConversionPattern<arith::TruncIOp> {
826-
using OpConversionPattern::OpConversionPattern;
826+
using Base::Base;
827827

828828
LogicalResult
829829
matchAndRewrite(arith::TruncIOp op, OpAdaptor adaptor,
@@ -853,7 +853,7 @@ struct TruncII1Pattern final : public OpConversionPattern<arith::TruncIOp> {
853853
/// Converts arith.trunci for cases where the type of result is neither i1
854854
/// nor vector of i1.
855855
struct TruncIPattern final : public OpConversionPattern<arith::TruncIOp> {
856-
using OpConversionPattern::OpConversionPattern;
856+
using Base::Base;
857857

858858
LogicalResult
859859
matchAndRewrite(arith::TruncIOp op, OpAdaptor adaptor,
@@ -963,7 +963,7 @@ struct TypeCastingOpPattern final : public OpConversionPattern<Op> {
963963
/// Converts integer compare operation on i1 type operands to SPIR-V ops.
964964
class CmpIOpBooleanPattern final : public OpConversionPattern<arith::CmpIOp> {
965965
public:
966-
using OpConversionPattern::OpConversionPattern;
966+
using Base::Base;
967967

968968
LogicalResult
969969
matchAndRewrite(arith::CmpIOp op, OpAdaptor adaptor,
@@ -1014,7 +1014,7 @@ class CmpIOpBooleanPattern final : public OpConversionPattern<arith::CmpIOp> {
10141014
/// Converts integer compare operation to SPIR-V ops.
10151015
class CmpIOpPattern final : public OpConversionPattern<arith::CmpIOp> {
10161016
public:
1017-
using OpConversionPattern::OpConversionPattern;
1017+
using Base::Base;
10181018

10191019
LogicalResult
10201020
matchAndRewrite(arith::CmpIOp op, OpAdaptor adaptor,
@@ -1063,7 +1063,7 @@ class CmpIOpPattern final : public OpConversionPattern<arith::CmpIOp> {
10631063
/// Converts floating-point comparison operations to SPIR-V ops.
10641064
class CmpFOpPattern final : public OpConversionPattern<arith::CmpFOp> {
10651065
public:
1066-
using OpConversionPattern::OpConversionPattern;
1066+
using Base::Base;
10671067

10681068
LogicalResult
10691069
matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor,
@@ -1103,7 +1103,7 @@ class CmpFOpPattern final : public OpConversionPattern<arith::CmpFOp> {
11031103
/// Kernel capability.
11041104
class CmpFOpNanKernelPattern final : public OpConversionPattern<arith::CmpFOp> {
11051105
public:
1106-
using OpConversionPattern::OpConversionPattern;
1106+
using Base::Base;
11071107

11081108
LogicalResult
11091109
matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor,
@@ -1128,7 +1128,7 @@ class CmpFOpNanKernelPattern final : public OpConversionPattern<arith::CmpFOp> {
11281128
/// require additional capability.
11291129
class CmpFOpNanNonePattern final : public OpConversionPattern<arith::CmpFOp> {
11301130
public:
1131-
using OpConversionPattern<arith::CmpFOp>::OpConversionPattern;
1131+
using Base::Base;
11321132

11331133
LogicalResult
11341134
matchAndRewrite(arith::CmpFOp op, OpAdaptor adaptor,
@@ -1170,7 +1170,7 @@ class CmpFOpNanNonePattern final : public OpConversionPattern<arith::CmpFOp> {
11701170
class AddUIExtendedOpPattern final
11711171
: public OpConversionPattern<arith::AddUIExtendedOp> {
11721172
public:
1173-
using OpConversionPattern::OpConversionPattern;
1173+
using Base::Base;
11741174
LogicalResult
11751175
matchAndRewrite(arith::AddUIExtendedOp op, OpAdaptor adaptor,
11761176
ConversionPatternRewriter &rewriter) const override {
@@ -1226,7 +1226,7 @@ class MulIExtendedOpPattern final : public OpConversionPattern<ArithMulOp> {
12261226
/// Converts arith.select to spirv.Select.
12271227
class SelectOpPattern final : public OpConversionPattern<arith::SelectOp> {
12281228
public:
1229-
using OpConversionPattern::OpConversionPattern;
1229+
using Base::Base;
12301230
LogicalResult
12311231
matchAndRewrite(arith::SelectOp op, OpAdaptor adaptor,
12321232
ConversionPatternRewriter &rewriter) const override {

mlir/lib/Conversion/ComplexToSPIRV/ComplexToSPIRV.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ using namespace mlir;
2727
namespace {
2828

2929
struct ConstantOpPattern final : OpConversionPattern<complex::ConstantOp> {
30-
using OpConversionPattern::OpConversionPattern;
30+
using Base::Base;
3131

3232
LogicalResult
3333
matchAndRewrite(complex::ConstantOp constOp, OpAdaptor adaptor,
@@ -46,7 +46,7 @@ struct ConstantOpPattern final : OpConversionPattern<complex::ConstantOp> {
4646
};
4747

4848
struct CreateOpPattern final : OpConversionPattern<complex::CreateOp> {
49-
using OpConversionPattern::OpConversionPattern;
49+
using Base::Base;
5050

5151
LogicalResult
5252
matchAndRewrite(complex::CreateOp createOp, OpAdaptor adaptor,
@@ -63,7 +63,7 @@ struct CreateOpPattern final : OpConversionPattern<complex::CreateOp> {
6363
};
6464

6565
struct ReOpPattern final : OpConversionPattern<complex::ReOp> {
66-
using OpConversionPattern::OpConversionPattern;
66+
using Base::Base;
6767

6868
LogicalResult
6969
matchAndRewrite(complex::ReOp reOp, OpAdaptor adaptor,
@@ -79,7 +79,7 @@ struct ReOpPattern final : OpConversionPattern<complex::ReOp> {
7979
};
8080

8181
struct ImOpPattern final : OpConversionPattern<complex::ImOp> {
82-
using OpConversionPattern::OpConversionPattern;
82+
using Base::Base;
8383

8484
LogicalResult
8585
matchAndRewrite(complex::ImOp imOp, OpAdaptor adaptor,

mlir/lib/Conversion/ControlFlowToSPIRV/ControlFlowToSPIRV.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ static LogicalResult legalizeBlockArguments(Block &block, Operation *op,
6262
namespace {
6363
/// Converts cf.br to spirv.Branch.
6464
struct BranchOpPattern final : OpConversionPattern<cf::BranchOp> {
65-
using OpConversionPattern::OpConversionPattern;
65+
using Base::Base;
6666

6767
LogicalResult
6868
matchAndRewrite(cf::BranchOp op, OpAdaptor adaptor,
@@ -79,7 +79,7 @@ struct BranchOpPattern final : OpConversionPattern<cf::BranchOp> {
7979

8080
/// Converts cf.cond_br to spirv.BranchConditional.
8181
struct CondBranchOpPattern final : OpConversionPattern<cf::CondBranchOp> {
82-
using OpConversionPattern::OpConversionPattern;
82+
using Base::Base;
8383

8484
LogicalResult
8585
matchAndRewrite(cf::CondBranchOp op, OpAdaptor adaptor,

mlir/lib/Conversion/FuncToSPIRV/FuncToSPIRV.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ namespace {
3434
/// Converts func.return to spirv.Return.
3535
class ReturnOpPattern final : public OpConversionPattern<func::ReturnOp> {
3636
public:
37-
using OpConversionPattern<func::ReturnOp>::OpConversionPattern;
37+
using Base::Base;
3838

3939
LogicalResult
4040
matchAndRewrite(func::ReturnOp returnOp, OpAdaptor adaptor,
@@ -55,7 +55,7 @@ class ReturnOpPattern final : public OpConversionPattern<func::ReturnOp> {
5555
/// Converts func.call to spirv.FunctionCall.
5656
class CallOpPattern final : public OpConversionPattern<func::CallOp> {
5757
public:
58-
using OpConversionPattern<func::CallOp>::OpConversionPattern;
58+
using Base::Base;
5959

6060
LogicalResult
6161
matchAndRewrite(func::CallOp callOp, OpAdaptor adaptor,

mlir/lib/Conversion/GPUToSPIRV/GPUToSPIRV.cpp

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ class WorkGroupSizeConversion : public OpConversionPattern<gpu::BlockDimOp> {
6969
/// Pattern to convert a kernel function in GPU dialect within a spirv.module.
7070
class GPUFuncOpConversion final : public OpConversionPattern<gpu::GPUFuncOp> {
7171
public:
72-
using OpConversionPattern<gpu::GPUFuncOp>::OpConversionPattern;
72+
using Base::Base;
7373

7474
LogicalResult
7575
matchAndRewrite(gpu::GPUFuncOp funcOp, OpAdaptor adaptor,
@@ -82,7 +82,7 @@ class GPUFuncOpConversion final : public OpConversionPattern<gpu::GPUFuncOp> {
8282
/// Pattern to convert a gpu.module to a spirv.module.
8383
class GPUModuleConversion final : public OpConversionPattern<gpu::GPUModuleOp> {
8484
public:
85-
using OpConversionPattern<gpu::GPUModuleOp>::OpConversionPattern;
85+
using Base::Base;
8686

8787
LogicalResult
8888
matchAndRewrite(gpu::GPUModuleOp moduleOp, OpAdaptor adaptor,
@@ -93,7 +93,7 @@ class GPUModuleConversion final : public OpConversionPattern<gpu::GPUModuleOp> {
9393
// TODO: This can go to DRR when GPU return has operands.
9494
class GPUReturnOpConversion final : public OpConversionPattern<gpu::ReturnOp> {
9595
public:
96-
using OpConversionPattern<gpu::ReturnOp>::OpConversionPattern;
96+
using Base::Base;
9797

9898
LogicalResult
9999
matchAndRewrite(gpu::ReturnOp returnOp, OpAdaptor adaptor,
@@ -103,7 +103,7 @@ class GPUReturnOpConversion final : public OpConversionPattern<gpu::ReturnOp> {
103103
/// Pattern to convert a gpu.barrier op into a spirv.ControlBarrier op.
104104
class GPUBarrierConversion final : public OpConversionPattern<gpu::BarrierOp> {
105105
public:
106-
using OpConversionPattern::OpConversionPattern;
106+
using Base::Base;
107107

108108
LogicalResult
109109
matchAndRewrite(gpu::BarrierOp barrierOp, OpAdaptor adaptor,
@@ -113,7 +113,7 @@ class GPUBarrierConversion final : public OpConversionPattern<gpu::BarrierOp> {
113113
/// Pattern to convert a gpu.shuffle op into a spirv.GroupNonUniformShuffle op.
114114
class GPUShuffleConversion final : public OpConversionPattern<gpu::ShuffleOp> {
115115
public:
116-
using OpConversionPattern::OpConversionPattern;
116+
using Base::Base;
117117

118118
LogicalResult
119119
matchAndRewrite(gpu::ShuffleOp shuffleOp, OpAdaptor adaptor,
@@ -123,7 +123,7 @@ class GPUShuffleConversion final : public OpConversionPattern<gpu::ShuffleOp> {
123123
/// Pattern to convert a gpu.rotate op into a spirv.GroupNonUniformRotateKHROp.
124124
class GPURotateConversion final : public OpConversionPattern<gpu::RotateOp> {
125125
public:
126-
using OpConversionPattern::OpConversionPattern;
126+
using Base::Base;
127127

128128
LogicalResult
129129
matchAndRewrite(gpu::RotateOp rotateOp, OpAdaptor adaptor,
@@ -132,7 +132,7 @@ class GPURotateConversion final : public OpConversionPattern<gpu::RotateOp> {
132132

133133
class GPUPrintfConversion final : public OpConversionPattern<gpu::PrintfOp> {
134134
public:
135-
using OpConversionPattern::OpConversionPattern;
135+
using Base::Base;
136136

137137
LogicalResult
138138
matchAndRewrite(gpu::PrintfOp gpuPrintfOp, OpAdaptor adaptor,
@@ -653,7 +653,7 @@ createGroupReduceOp(OpBuilder &builder, Location loc, Value arg,
653653
class GPUAllReduceConversion final
654654
: public OpConversionPattern<gpu::AllReduceOp> {
655655
public:
656-
using OpConversionPattern::OpConversionPattern;
656+
using Base::Base;
657657

658658
LogicalResult
659659
matchAndRewrite(gpu::AllReduceOp op, OpAdaptor adaptor,
@@ -680,7 +680,7 @@ class GPUAllReduceConversion final
680680
class GPUSubgroupReduceConversion final
681681
: public OpConversionPattern<gpu::SubgroupReduceOp> {
682682
public:
683-
using OpConversionPattern::OpConversionPattern;
683+
using Base::Base;
684684

685685
LogicalResult
686686
matchAndRewrite(gpu::SubgroupReduceOp op, OpAdaptor adaptor,

0 commit comments

Comments
 (0)