WIP accept double/int inputs and downcast to floats

Author: kmpeng

clang/lib/Headers/hlsl/hlsl_compat_overloads.h

@@ -280,6 +280,15 @@ constexpr bool4 isinf(double4 V) { return isinf((float4)V); }
 _DXC_COMPAT_TERNARY_DOUBLE_OVERLOADS(lerp)
 _DXC_COMPAT_TERNARY_INTEGER_OVERLOADS(lerp)
 
+//===----------------------------------------------------------------------===//
+// lit builtins overloads
+//===----------------------------------------------------------------------===//
+constexpr float4 lit(double V1, double V2, double V3) { return lit((float)V1, (float)V2, (float)V3); }
+constexpr float4 lit(int V1, int V2, int V3) { return lit((float)V1, (float)V2, (float)V3); }
+constexpr float4 lit(uint V1, uint V2, uint V3) { return lit((float)V1, (float)V2, (float)V3); }
+constexpr float4 lit(int64_t V1, int64_t V2, int64_t V3) { return lit((float)V1, (float)V2, (float)V3); }
+constexpr float4 lit(uint64_t V1, uint64_t V2, uint64_t V3) { return lit((float)V1, (float)V2, (float)V3); }
+
 //===----------------------------------------------------------------------===//
 // log builtins overloads
 //===----------------------------------------------------------------------===//

clang/test/CodeGenHLSL/builtins/lit-overloads.hlsl

@@ -0,0 +1,23 @@
+// RUN: %clang_cc1 -std=hlsl202x -finclude-default-header -x hlsl -triple dxil-pc-shadermodel6.3-library %s \
+// RUN:  -emit-llvm -disable-llvm-passes -o - | \
+// RUN:  FileCheck %s --check-prefixes=CHECK
+
+// CHECK-LABEL: define noundef nofpclass(nan inf) float {{.*}}test_floor_double
+// CHECK: call reassoc nnan ninf nsz arcp afn float @llvm.floor.f32(
+float4 test_lit_double(double NDotL, double NDotH, double M) { return lit(NDotL, NDotH, M); }
+
+// CHECK-LABEL: define noundef nofpclass(nan inf) float {{.*}}test_floor_int
+// CHECK: call reassoc nnan ninf nsz arcp afn float @llvm.floor.f32(
+float4 test_lit_int(int NDotL, int NDotH, int M) { return lit(NDotL, NDotH, M); }
+
+// CHECK-LABEL: define noundef nofpclass(nan inf) float {{.*}}test_floor_uint
+// CHECK: call reassoc nnan ninf nsz arcp afn float @llvm.floor.f32(
+float4 test_lit_uint(uint NDotL, uint NDotH, uint M) { return lit(NDotL, NDotH, M); }
+
+// CHECK-LABEL: define noundef nofpclass(nan inf) float {{.*}}test_floor_int64_t
+// CHECK: call reassoc nnan ninf nsz arcp afn float @llvm.floor.f32(
+float4 test_lit_int64_t(int64_t NDotL, int64_t NDotH, int64_t M) { return lit(NDotL, NDotH, M); }
+
+// CHECK-LABEL: define noundef nofpclass(nan inf) float {{.*}}test_floor_uint64_t
+// CHECK: call reassoc nnan ninf nsz arcp afn float @llvm.floor.f32(
+float4 test_lit_uint64_t(uint64_t NDotL, uint64_t NDotH, uint64_t M) { return lit(NDotL, NDotH, M); }

clang/test/SemaHLSL/BuiltIns/lit-errors.hlsl

@@ -21,20 +21,6 @@ float4 test_too_many_arg(float p0) {
   // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate function template not viable: requires 3 arguments, but 4 were provided}}
 }
 
-float4 test_double_inputs(double p0, double p1, double p2) {
-  return lit(p0, p1, p2);
-  // expected-error@-1  {{no matching function for call to 'lit'}}
-  // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = double]: no type named 'Type' in 'hlsl::__detail::enable_if<false, vector<double, 4>>'}}
-  // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = double]: no type named 'Type' in 'hlsl::__detail::enable_if<false, vector<double, 4>>'}}
-}
-
-float4 test_int_inputs(int p0, int p1, int p2) {
-  return lit(p0, p1, p2);
-  // expected-error@-1  {{no matching function for call to 'lit'}}
-  // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = int]: no type named 'Type' in 'hlsl::__detail::enable_if<false, vector<int, 4>>'}}
-  // expected-note@hlsl/hlsl_intrinsics.h:* {{candidate template ignored: substitution failure [with T = int]: no type named 'Type' in 'hlsl::__detail::enable_if<false, vector<int, 4>>'}}
-}
-
 float4 test_vec_inputs(float2 p0, float2 p1, float2 p2) {
   return lit(p0, p1, p2);
   // expected-error@-1  {{no matching function for call to 'lit'}}