Use instr-ref bit instead of high-level function

Author: SLTozer

llvm/lib/CodeGen/RemoveLoadsIntoFakeUses.cpp

@@ -34,8 +34,6 @@
 #include "llvm/Support/Debug.h"
 #include "llvm/Target/TargetMachine.h"
 
-#include "LiveDebugValues/LiveDebugValues.h"
-
 using namespace llvm;
 
 #define DEBUG_TYPE "remove-loads-into-fake-uses"
@@ -79,7 +77,7 @@ INITIALIZE_PASS_END(RemoveLoadsIntoFakeUses, DEBUG_TYPE,
 bool RemoveLoadsIntoFakeUses::runOnMachineFunction(MachineFunction &MF) {
   // Skip this pass if we would use VarLoc-based LDV, as there may be DBG_VALUE
   // instructions of the restored values that would become invalid.
-  if (!MF.shouldUseDebugInstrRef())
+  if (!MF.useDebugInstrRef())
     return false;
   // Only run this for functions that have fake uses.
   if (!MF.hasFakeUses() || skipFunction(MF.getFunction()))

llvm/test/CodeGen/X86/fake-use-remove-loads.mir

@@ -1,8 +1,9 @@
 # NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py UTC_ARGS: --version 5
 # Ensure that loads into FAKE_USEs are correctly removed by the
-# remove-loads-into-fake-uses pass.
-# RUN: llc -run-pass remove-loads-into-fake-uses -mtriple=x86_64-unknown-linux -debug-only=remove-loads-into-fake-uses 2>&1 -o - %s | FileCheck %s --check-prefix=ENABLED
-# RUN: llc -run-pass remove-loads-into-fake-uses -mtriple=x86_64-unknown-linux -debug-only=remove-loads-into-fake-uses -experimental-debug-variable-locations=false 2>&1 -o - %s | FileCheck %s --check-prefixes=DISABLED
+# remove-loads-into-fake-uses pass, and that if the function does not use
+# instruction referencing then no changes are made.
+# RUN: sed 's/USE_INSTR_REF/true/'  %s | llc - -x mir -run-pass remove-loads-into-fake-uses -mtriple=x86_64-unknown-linux -debug-only=remove-loads-into-fake-uses 2>&1 -o - | FileCheck %s --check-prefix=ENABLED
+# RUN: sed 's/USE_INSTR_REF/false/' %s | llc - -x mir -run-pass remove-loads-into-fake-uses -mtriple=x86_64-unknown-linux -debug-only=remove-loads-into-fake-uses 2>&1 -o - | FileCheck %s --check-prefixes=DISABLED
 # REQUIRES: asserts
 #
 ## We verify that:
@@ -22,6 +23,7 @@ tracksRegLiveness: true
 noPhis:          true
 noVRegs:         true
 hasFakeUses:     true
+debugInstrRef:   USE_INSTR_REF
 tracksDebugUserValues: true
 liveins:
   - { reg: '$rdi', virtual-reg: '' }