Skip to content

Commit 02bfb8c

Browse files
authored
[AMDGPU][SIInsertWaitCnts] Add todos
1 parent 7708bb6 commit 02bfb8c

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -531,6 +531,7 @@ class SIInsertWaitcnts {
531531
// instruction.
532532
WaitEventType getVmemWaitEventType(const MachineInstr &Inst) const {
533533
switch (Inst.getOpcode()) {
534+
// FIXME: GLOBAL_INV needs to be tracked with xcnt too.
534535
case AMDGPU::GLOBAL_INV:
535536
return VMEM_READ_ACCESS; // tracked using loadcnt
536537
case AMDGPU::GLOBAL_WB:
@@ -1310,6 +1311,7 @@ void WaitcntBrackets::simplifyXcnt(AMDGPU::Waitcnt &CheckWait,
13101311
// optimizations. On entry to a block with multiple predescessors, there may
13111312
// be pending SMEM and VMEM events active at the same time.
13121313
// In such cases, only clear one active event at a time.
1314+
// TODO: Revisit xcnt optimizations for gfx1250.
13131315
if (hasRedundantXCntWithKmCnt(CheckWait)) {
13141316
if (!hasMixedPendingEvents(X_CNT)) {
13151317
applyWaitcnt(X_CNT, 0);

0 commit comments

Comments
 (0)