[HIP] Emit the CUID value in the module with the new driver

jhuber6 · jhuber6 · commit 02fa317d90df · 2025-06-17T12:03:01.000-05:00
Summary:
This is a weird point of divergence, which is also apparently critical
for SPIR-V compilation not failing? Somehow if we don't emit this global
than the `llvm.compiler.used` global uses AS(0) which makes SPIR-V
unhappy, but with this global it's AS(4) which makes it happy. Either
way, this should be fixed.
diff --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -969,7 +969,7 @@ void CodeGenModule::Release() {
         llvm::ConstantArray::get(ATy, UsedArray), "__clang_gpu_used_external");
     addCompilerUsedGlobal(GV);
   }
-  if (LangOpts.HIP && !getLangOpts().OffloadingNewDriver) {
+  if (LangOpts.HIP) {
     // Emit a unique ID so that host and device binaries from the same
     // compilation unit can be associated.
     auto *GV = new llvm::GlobalVariable(

Original file line number	Diff line number	Diff line change
`@@ -969,7 +969,7 @@ void CodeGenModule::Release() {`
`969`	`969`	`llvm::ConstantArray::get(ATy, UsedArray), "__clang_gpu_used_external");`
`970`	`970`	`addCompilerUsedGlobal(GV);`
`971`	`971`	`}`
`972`		`- if (LangOpts.HIP && !getLangOpts().OffloadingNewDriver) {`
	`972`	`+ if (LangOpts.HIP) {`
`973`	`973`	`// Emit a unique ID so that host and device binaries from the same`
`974`	`974`	`// compilation unit can be associated.`
`975`	`975`	`auto *GV = new llvm::GlobalVariable(`