Skip to content

Commit 0329fad

Browse files
committed
comment
1 parent ac8de1e commit 0329fad

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

mlir/lib/Dialect/Arith/Transforms/UnsignedWhenEquivalent.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ using namespace mlir::dataflow;
3030
/// Succeeds when a value is statically non-negative in that it has a lower
3131
/// bound on its value (if it is treated as signed) and that bound is
3232
/// non-negative.
33+
// TODO: IntegerRangeAnalysis internally assumes index is 64bit and this pattern
34+
// relies on this. These transformations may not be valid for 32bit index,
35+
// need more investigation.
3336
static LogicalResult staticallyNonNegative(DataFlowSolver &solver, Value v) {
3437
auto *result = solver.lookupState<IntegerValueRangeLattice>(v);
3538
if (!result || result->getValue().isUninitialized())

0 commit comments

Comments
 (0)