Skip to content

Commit 0344761

Browse files
committed
fix minor issues
1 parent bbd43d0 commit 0344761

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

mlir/lib/Conversion/XeGPUToXeVM/XeGPUToXeVM.cpp

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,8 @@ static int32_t getNumericXeVMAddrSpace(xegpu::MemorySpace xeGpuMemspace) {
6161
return static_cast<int>(xevm::AddrSpace::GLOBAL);
6262
case xegpu::MemorySpace::SLM:
6363
return static_cast<int>(xevm::AddrSpace::SHARED);
64-
default:
65-
llvm_unreachable("Unknown XeGPU memory space");
66-
return static_cast<int>(xevm::AddrSpace::GLOBAL);
6764
}
65+
llvm_unreachable("Unknown XeGPU memory space");
6866
}
6967

7068
// Get same bitwidth flat vector type of new element type.
@@ -186,8 +184,9 @@ class CreateNdDescToXeVMPattern
186184
SmallVector<OpFoldResult> mixedSizes = op.getMixedSizes();
187185
// Descriptor shape is expected to be 2D.
188186
int64_t rank = mixedSizes.size();
189-
if (rank != 2)
187+
if (rank != 2) {
190188
return rewriter.notifyMatchFailure(op, "Expected 2D shape.");
189+
}
191190
auto sourceTy = source.getType();
192191
auto sourceMemrefTy = dyn_cast<MemRefType>(sourceTy);
193192
// If source is a memref, we need to extract the aligned pointer as index.
@@ -612,8 +611,7 @@ class LoadStoreMatrixToXeVMPattern : public OpConversionPattern<OpType> {
612611
LLVM::LoadOp::create(rewriter, loc, scalarTy, basePtrLLVM);
613612
rewriter.replaceOp(op, loadOp);
614613
} else {
615-
auto storeOp = LLVM::StoreOp::create(rewriter, loc, adaptor.getData(),
616-
basePtrLLVM);
614+
LLVM::StoreOp::create(rewriter, loc, adaptor.getData(), basePtrLLVM);
617615
rewriter.eraseOp(op);
618616
}
619617
return success();
@@ -680,8 +678,7 @@ class LoadStoreMatrixToXeVMPattern : public OpConversionPattern<OpType> {
680678
LLVM::LoadOp::create(rewriter, loc, valOrResVecTy, basePtrLLVM);
681679
rewriter.replaceOp(op, loadOp);
682680
} else {
683-
auto storeOp = LLVM::StoreOp::create(rewriter, loc, adaptor.getData(),
684-
basePtrLLVM);
681+
LLVM::StoreOp::create(rewriter, loc, adaptor.getData(), basePtrLLVM);
685682
rewriter.eraseOp(op);
686683
}
687684
}

0 commit comments

Comments
 (0)