Skip to content

Commit 0359aed

Browse files
[AMDGPU] Simplify GetMember...::Get (NFC)
We can use "constexpr if" to combine the two variants of functions.
1 parent 7904298 commit 0359aed

File tree

1 file changed

+8
-11
lines changed

1 file changed

+8
-11
lines changed

llvm/lib/Target/AMDGPU/Utils/AMDKernelCodeTUtils.cpp

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -72,17 +72,14 @@ using namespace llvm::AMDGPU;
7272
class GetMember##member { \
7373
public: \
7474
static const MCExpr *Phony; \
75-
template <typename U, typename std::enable_if_t<IsMCExpr##member::RESULT, \
76-
U> * = nullptr> \
77-
static const MCExpr *&Get(U &C) { \
78-
assert(IsMCExpr##member::RESULT && \
79-
"Trying to retrieve member that does not exist."); \
80-
return C.member; \
81-
} \
82-
template <typename U, typename std::enable_if_t<!IsMCExpr##member::RESULT, \
83-
U> * = nullptr> \
84-
static const MCExpr *&Get(U &C) { \
85-
return Phony; \
75+
template <typename U> static const MCExpr *&Get(U &C) { \
76+
if constexpr (IsMCExpr##member::RESULT) { \
77+
assert(IsMCExpr##member::RESULT && \
78+
"Trying to retrieve member that does not exist."); \
79+
return C.member; \
80+
} else { \
81+
return Phony; \
82+
} \
8683
} \
8784
}; \
8885
const MCExpr *GetMember##member::Phony = nullptr;

0 commit comments

Comments
 (0)