Skip to content

Commit 038e80c

Browse files
authored
[libc++][Android] Update compiler and sysroot (#148998)
* Upgrade from r536225 to r563880. * Upgrade from ab/12644632 to f8b85cc5262c6e5cbc9a92c1bab2b18b32a4c63f, the current HEAD commit of https://android.googlesource.com/platform/prebuilts/ndk/+/refs/heads/mirror-goog-main-ndk The previous source of sysroots (ci.android.com), deleted its artifacts after a short period of time, and is currently out-of-date because of the aosp-main turndown. Updating the Docker image also fixes two tests.
1 parent 703501e commit 038e80c

File tree

4 files changed

+15
-16
lines changed

4 files changed

+15
-16
lines changed

libcxx/test/std/utilities/meta/meta.unary/meta.unary.comp/is_bounded_array.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
// UNSUPPORTED: c++03, c++11, c++14, c++17
99

1010
// The Clang version that Android currently uses in the CI is too old.
11-
// XFAIL: LIBCXX-ANDROID-FIXME
11+
// UNSUPPORTED: LIBCXX-ANDROID-FIXME
1212

1313
// type_traits
1414

libcxx/test/std/utilities/meta/meta.unary/meta.unary.prop/has_unique_object_representations.compile.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// UNSUPPORTED: c++03, c++11, c++14
1010

1111
// The Clang version that Android currently uses in the CI is too old.
12-
// XFAIL: LIBCXX-ANDROID-FIXME
12+
// UNSUPPORTED: LIBCXX-ANDROID-FIXME
1313

1414
// type_traits
1515

libcxx/utils/ci/Dockerfile

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ FROM ubuntu:jammy AS android-builder-base
184184

185185
ARG ANDROID_CLANG_VERSION
186186
ARG ANDROID_CLANG_PREBUILTS_COMMIT
187-
ARG ANDROID_SYSROOT_BID
187+
ARG ANDROID_SYSROOT_COMMIT
188188

189189
RUN apt-get update && apt-get install -y curl bzip2 git unzip
190190

@@ -217,19 +217,18 @@ RUN <<EOF
217217
ls /opt/android/clang/clang-current/bin/clang
218218
EOF
219219

220-
# Install an Android sysroot. New AOSP sysroots are available at
221-
# https://ci.android.com/builds/branches/aosp-main/grid, the "ndk" target. The
222-
# NDK also makes its sysroot prebuilt available at
223-
# https://android.googlesource.com/platform/prebuilts/ndk/+/refs/heads/dev/platform/sysroot.
220+
# Install an Android sysroot. New Android sysroots are available at
221+
# https://android.googlesource.com/platform/prebuilts/ndk/+/refs/heads/mirror-goog-main-ndk/platform/sysroot.
224222

225-
ENV ANDROID_SYSROOT_BID=$ANDROID_SYSROOT_BID
223+
ENV ANDROID_SYSROOT_COMMIT=$ANDROID_SYSROOT_COMMIT
226224
RUN <<EOF
227225
set -e
228-
cd /opt/android
229-
curl -L -o ndk_platform.tar.bz2 \
230-
https://androidbuildinternal.googleapis.com/android/internal/build/v3/builds/${ANDROID_SYSROOT_BID}/ndk/attempts/latest/artifacts/ndk_platform.tar.bz2/url
231-
tar xf ndk_platform.tar.bz2
232-
rm ndk_platform.tar.bz2
226+
mkdir -p /opt/android/ndk
227+
cd /opt/android/ndk
228+
git clone --filter=blob:none https://android.googlesource.com/platform/prebuilts/ndk tmp
229+
git -C tmp checkout ${ANDROID_SYSROOT_COMMIT}
230+
mv tmp/platform/sysroot .
231+
rm -rf tmp
233232
EOF
234233

235234
# ===----------------------------------------------------------------------===##

libcxx/utils/ci/docker-compose.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ services:
2121
target: android-buildkite-builder
2222
args:
2323
BASE_IMAGE: ubuntu:noble
24-
ANDROID_CLANG_VERSION: r536225
25-
ANDROID_CLANG_PREBUILTS_COMMIT: 3f67b93ee7a50ae2a3cb34cc32d0589415cc0a9c
26-
ANDROID_SYSROOT_BID: 12644632
24+
ANDROID_CLANG_VERSION: r563880
25+
ANDROID_CLANG_PREBUILTS_COMMIT: 6ae4184bb8706f9731569b9a0a82be3fcdcb951c
26+
ANDROID_SYSROOT_COMMIT: f8b85cc5262c6e5cbc9a92c1bab2b18b32a4c63f
2727
<<: *compiler_versions

0 commit comments

Comments
 (0)