Address comments.

Author: kazutakahirata

llvm/include/llvm/Transforms/Instrumentation/MemProfiler.h

@@ -66,9 +66,11 @@ namespace memprof {
 
 // Extract all calls from the IR.  Arrange them in a map from caller GUIDs to a
 // list of call sites, each of the form {LineLocation, CalleeGUID}.
-DenseMap<uint64_t, SmallVector<CallEdgeTy, 0>>
-extractCallsFromIR(Module &M, const TargetLibraryInfo &TLI,
-                   function_ref<bool(uint64_t)> IsPresentInProfile);
+DenseMap<uint64_t, SmallVector<CallEdgeTy, 0>> extractCallsFromIR(
+    Module &M, const TargetLibraryInfo &TLI,
+    function_ref<bool(uint64_t)> IsPresentInProfile = [](uint64_t) {
+      return true;
+    });
 
 struct LineLocationHash {
   uint64_t operator()(const LineLocation &Loc) const {

llvm/test/Transforms/PGOProfile/memprof_undrift_missing_leaf.ll

@@ -2,9 +2,6 @@
 ;; This test case is taken from memprof_missing_leaf.ll with the profile
 ;; drifted.
 
-;; Avoid failures on big-endian systems that can't read the profile properly
-; REQUIRES: x86_64-linux
-
 ; RUN: split-file %s %t
 ; RUN: llvm-profdata merge %t/memprof_missing_leaf.yaml -o %t/memprof_missing_leaf.memprofdata
 ; RUN: opt < %t/memprof_missing_leaf.ll -passes='memprof-use<profile-filename=%t/memprof_missing_leaf.memprofdata>' -memprof-salvage-stale-profile -S | FileCheck %s
@@ -19,8 +16,6 @@ HeapProfileRecords:
         MemInfoBlock:
           AllocCount:      1
           TotalSize:       1
-          TotalLifetime:   0
-          TotalLifetimeAccessDensity: 0
     CallSites:       []
 ...
 ;--- memprof_missing_leaf.ll

llvm/unittests/Transforms/Instrumentation/MemProfUseTest.cpp

@@ -92,8 +92,7 @@ declare !dbg !19 void @_Z2f3v()
 
   TargetLibraryInfoWrapperPass WrapperPass;
   auto &TLI = WrapperPass.getTLI(*F);
-  auto IsPresentInProfile = [](uint64_t) { return true; };
-  auto Calls = extractCallsFromIR(*M, TLI, IsPresentInProfile);
+  auto Calls = extractCallsFromIR(*M, TLI);
 
   // Expect exactly one caller.
   ASSERT_THAT(Calls, SizeIs(1));
@@ -194,8 +193,7 @@ declare !dbg !25 void @_Z2g2v() local_unnamed_addr
 
   TargetLibraryInfoWrapperPass WrapperPass;
   auto &TLI = WrapperPass.getTLI(*F);
-  auto IsPresentInProfile = [](uint64_t) { return true; };
-  auto Calls = extractCallsFromIR(*M, TLI, IsPresentInProfile);
+  auto Calls = extractCallsFromIR(*M, TLI);
 
   // Expect exactly 4 callers.
   ASSERT_THAT(Calls, SizeIs(4));
@@ -290,8 +288,7 @@ attributes #2 = { builtin allocsize(0) }
 
   TargetLibraryInfoWrapperPass WrapperPass;
   auto &TLI = WrapperPass.getTLI(*F);
-  auto IsPresentInProfile = [](uint64_t) { return true; };
-  auto Calls = extractCallsFromIR(*M, TLI, IsPresentInProfile);
+  auto Calls = extractCallsFromIR(*M, TLI);
 
   // Expect exactly one caller.
   ASSERT_THAT(Calls, SizeIs(1));
@@ -407,8 +404,7 @@ attributes #1 = { "no-trapping-math"="true" "stack-protector-buffer-size"="8" "t
 
   TargetLibraryInfoWrapperPass WrapperPass;
   auto &TLI = WrapperPass.getTLI(*F);
-  auto IsPresentInProfile = [](uint64_t) { return true; };
-  auto Calls = extractCallsFromIR(*M, TLI, IsPresentInProfile);
+  auto Calls = extractCallsFromIR(*M, TLI);
 
   uint64_t GUIDFoo = IndexedMemProfRecord::getGUID("_Z3foov");
   uint64_t GUIDBar = IndexedMemProfRecord::getGUID("_Z3barv");