Skip to content

Commit 044c46f

Browse files
committed
fixup! Address comments
Change-Id: I2b113335c55ebd058ecfcf50e8767bc152d25850
1 parent 178eea8 commit 044c46f

File tree

3 files changed

+12
-14
lines changed

3 files changed

+12
-14
lines changed

llvm/lib/Target/RISCV/RISCVExpandPseudoInsts.cpp

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ bool RISCVExpandPseudo::expandMI(MachineBasicBlock &MBB,
133133
case RISCV::PseudoCCMINU:
134134
case RISCV::PseudoCCMUL:
135135
case RISCV::PseudoCCLUI:
136-
case RISCV::PseudoCCQCLI:
137-
case RISCV::PseudoCCQCELI:
136+
case RISCV::PseudoCCQC_LI:
137+
case RISCV::PseudoCCQC_E_LI:
138138
case RISCV::PseudoCCADDW:
139139
case RISCV::PseudoCCSUBW:
140140
case RISCV::PseudoCCSLL:
@@ -243,8 +243,8 @@ bool RISCVExpandPseudo::expandCCOp(MachineBasicBlock &MBB,
243243
case RISCV::PseudoCCMINU: NewOpc = RISCV::MINU; break;
244244
case RISCV::PseudoCCMUL: NewOpc = RISCV::MUL; break;
245245
case RISCV::PseudoCCLUI: NewOpc = RISCV::LUI; break;
246-
case RISCV::PseudoCCQCLI: NewOpc = RISCV::QC_LI; break;
247-
case RISCV::PseudoCCQCELI: NewOpc = RISCV::QC_E_LI; break;
246+
case RISCV::PseudoCCQC_LI: NewOpc = RISCV::QC_LI; break;
247+
case RISCV::PseudoCCQC_E_LI: NewOpc = RISCV::QC_E_LI; break;
248248
case RISCV::PseudoCCADDI: NewOpc = RISCV::ADDI; break;
249249
case RISCV::PseudoCCSLLI: NewOpc = RISCV::SLLI; break;
250250
case RISCV::PseudoCCSRLI: NewOpc = RISCV::SRLI; break;
@@ -274,10 +274,8 @@ bool RISCVExpandPseudo::expandCCOp(MachineBasicBlock &MBB,
274274
.add(MI.getOperand(5))
275275
.add(MI.getOperand(6))
276276
.add(MI.getOperand(7));
277-
}
278-
279-
else if (NewOpc == RISCV::LUI || NewOpc == RISCV::QC_LI ||
280-
NewOpc == RISCV::QC_E_LI) {
277+
} else if (NewOpc == RISCV::LUI || NewOpc == RISCV::QC_LI ||
278+
NewOpc == RISCV::QC_E_LI) {
281279
BuildMI(TrueBB, DL, TII->get(NewOpc), DestReg).add(MI.getOperand(5));
282280
} else {
283281
BuildMI(TrueBB, DL, TII->get(NewOpc), DestReg)

llvm/lib/Target/RISCV/RISCVInstrInfo.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1705,8 +1705,8 @@ unsigned getPredicatedOpcode(unsigned Opcode) {
17051705
case RISCV::MINU: return RISCV::PseudoCCMINU;
17061706
case RISCV::MUL: return RISCV::PseudoCCMUL;
17071707
case RISCV::LUI: return RISCV::PseudoCCLUI;
1708-
case RISCV::QC_LI: return RISCV::PseudoCCQCLI;
1709-
case RISCV::QC_E_LI: return RISCV::PseudoCCQCELI;
1708+
case RISCV::QC_LI: return RISCV::PseudoCCQC_LI;
1709+
case RISCV::QC_E_LI: return RISCV::PseudoCCQC_E_LI;
17101710

17111711
case RISCV::ADDI: return RISCV::PseudoCCADDI;
17121712
case RISCV::SLLI: return RISCV::PseudoCCSLLI;

llvm/lib/Target/RISCV/RISCVInstrInfoXqci.td

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ class QCIRVInst48EJ<bits<2> func2, string opcodestr>
817817
let Inst{6-0} = 0b0011111;
818818
}
819819

820-
class SFBQCLI
820+
class SFBQC_LI
821821
: Pseudo<(outs GPR:$dst),
822822
(ins GPR:$lhs, GPR:$rhs, cond_code:$cc, GPR:$falsev,
823823
simm20_li:$imm), []> {
@@ -828,7 +828,7 @@ class SFBQCLI
828828
let Constraints = "$dst = $falsev";
829829
}
830830

831-
class SFBQCELI
831+
class SFBQC_E_LI
832832
: Pseudo<(outs GPR:$dst),
833833
(ins GPR:$lhs, GPR:$rhs, cond_code:$cc, GPR:$falsev,
834834
bare_simm32:$imm), []> {
@@ -1331,8 +1331,8 @@ def PseudoQC_E_SW : PseudoStore<"qc.e.sw">;
13311331
} // Predicates = [HasVendorXqcilo, IsRV32]
13321332

13331333
let Predicates = [HasShortForwardBranchOpt] in {
1334-
def PseudoCCQCLI : SFBQCLI;
1335-
def PseudoCCQCELI : SFBQCELI;
1334+
def PseudoCCQC_LI : SFBQC_LI;
1335+
def PseudoCCQC_E_LI : SFBQC_E_LI;
13361336
}
13371337

13381338
//===----------------------------------------------------------------------===//

0 commit comments

Comments
 (0)