misc clean up

Author: inbelic

clang/lib/Sema/SemaHLSL.cpp

@@ -1155,10 +1155,9 @@ bool SemaHLSL::handleRootSignatureElements(
     }
   }
 
-  // Sort as specified
-  auto ComparePairs = [](InfoPair A, InfoPair B) { return A.first < B.first; };
-
-  std::sort(InfoPairs.begin(), InfoPairs.end(), ComparePairs);
+  // 2. Sort with the RangeInfo <operator to prepare it for findOverlapping
+  std::sort(InfoPairs.begin(), InfoPairs.end(),
+            [](InfoPair A, InfoPair B) { return A.first < B.first; });
 
   llvm::SmallVector<RangeInfo> Infos;
   for (const InfoPair &Pair : InfoPairs)
@@ -1205,6 +1204,7 @@ bool SemaHLSL::handleRootSignatureElements(
     this->Diag(OElem->getLocation(), diag::note_hlsl_resource_range_here);
   };
 
+  // 3. Invoke find overlapping ranges
   llvm::SmallVector<OverlappingRanges> Overlaps =
       llvm::hlsl::rootsig::findOverlappingRanges(Infos);
   for (OverlappingRanges Overlap : Overlaps)

llvm/include/llvm/Frontend/HLSL/RootSignatureValidations.h

@@ -137,8 +137,8 @@ struct OverlappingRanges {
 ///   - RangeInfo will retain the interval, ResourceClass, Space and Visibility
 ///   - It will also contain an index so that it can be associated to
 /// additional diagnostic information
-/// 2. Sort the RangeInfo's such that they are grouped together by
-///  ResourceClass and Space
+/// 2. The user is required to sort the RangeInfo's such that they are grouped
+/// together by ResourceClass and Space
 /// 3. Iterate through the collected RangeInfos by their groups
 ///   - For each group we will have a ResourceRange for each visibility
 ///   - As we iterate through we will:

llvm/lib/Frontend/HLSL/RootSignatureValidations.cpp

@@ -245,7 +245,8 @@ std::optional<const RangeInfo *> ResourceRange::insert(const RangeInfo &Info) {
 
 llvm::SmallVector<OverlappingRanges>
 findOverlappingRanges(ArrayRef<RangeInfo> Infos) {
-  // 1. The user has provided the corresponding range information
+  // It is expected that Infos is filled with valid RangeInfos and that
+  // they are sorted with respect to the RangeInfo <operator
   llvm::SmallVector<OverlappingRanges> Overlaps;
   using GroupT = std::pair<dxil::ResourceClass, /*Space*/ uint32_t>;