AS comments

Author: optimisan

llvm/include/llvm/CodeGen/SpillPlacement.h

@@ -160,8 +160,7 @@ class SpillPlacement {
   bool invalidate(MachineFunction &MF, const PreservedAnalyses &PA,
                   MachineFunctionAnalysisManager::Invalidator &Inv);
 
-  // Move the default definitions to the implementation
-  // so the full definition of Node is available.
+  // Out of line definitions so unique_ptr<Node[]> doesn't need to be complete.
   SpillPlacement(SpillPlacement &&);
   ~SpillPlacement();
 

llvm/include/llvm/Passes/MachinePassRegistry.def

@@ -112,8 +112,8 @@ MACHINE_FUNCTION_ANALYSIS("machine-post-dom-tree",
                           MachinePostDominatorTreeAnalysis())
 MACHINE_FUNCTION_ANALYSIS("machine-trace-metrics", MachineTraceMetricsAnalysis())
 MACHINE_FUNCTION_ANALYSIS("pass-instrumentation", PassInstrumentationAnalysis(PIC))
-MACHINE_FUNCTION_ANALYSIS("spill-code-placement", SpillPlacementAnalysis())
 MACHINE_FUNCTION_ANALYSIS("slot-indexes", SlotIndexesAnalysis())
+MACHINE_FUNCTION_ANALYSIS("spill-code-placement", SpillPlacementAnalysis())
 MACHINE_FUNCTION_ANALYSIS("virtregmap", VirtRegMapAnalysis())
 // MACHINE_FUNCTION_ANALYSIS("live-stacks", LiveStacksPass())
 // MACHINE_FUNCTION_ANALYSIS("lazy-machine-bfi",

llvm/lib/CodeGen/SpillPlacement.cpp

@@ -213,9 +213,10 @@ bool SpillPlacementAnalysis::Result::invalidate(
     MachineFunction &MF, const PreservedAnalyses &PA,
     MachineFunctionAnalysisManager::Invalidator &Inv) {
   auto PAC = PA.getChecker<SpillPlacementAnalysis>();
-  return (!PAC.preserved() &&
-          !PAC.preservedSet<AllAnalysesOn<MachineFunction>>()) ||
-         Inv.invalidate<EdgeBundlesAnalysis>(MF, PA) ||
+  if (!PAC.preserved() && !PAC.preservedSet<AllAnalysesOn<MachineFunction>>())
+    return true;
+  // Check dependencies.
+  return Inv.invalidate<EdgeBundlesAnalysis>(MF, PA) ||
          Inv.invalidate<MachineBlockFrequencyAnalysis>(MF, PA);
 }