Skip to content

Commit 05a6255

Browse files
authored
Merge branch 'main' into atmn/add-default-attr-to-present
2 parents 67eef63 + 6ed829b commit 05a6255

File tree

5 files changed

+8
-12
lines changed

5 files changed

+8
-12
lines changed

lld/COFF/DriverUtils.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -862,6 +862,9 @@ opt::InputArgList ArgParser::parse(ArrayRef<const char *> argv) {
862862
<< "', did you mean '" << nearest << "'";
863863
}
864864

865+
if (args.hasArg(OPT_link))
866+
Warn(ctx) << "ignoring /link, did you pass it multiple times?";
867+
865868
if (args.hasArg(OPT_lib))
866869
Warn(ctx) << "ignoring /lib since it's not the first argument";
867870

lld/COFF/Options.td

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ def noimplib : F<"noimplib">,
7171
def lib : F<"lib">,
7272
HelpText<"Act like lib.exe; must be first argument if present">;
7373
def libpath : P<"libpath", "Additional library search path">;
74+
def link : F<"link">, HelpText<"Ignored for compatibility">;
7475
def linkrepro : Joined<["/", "-", "/?", "-?"], "linkrepro:">,
7576
MetaVarName<"directory">,
7677
HelpText<"Write repro.tar containing inputs and command to reproduce link">;

lld/test/COFF/driver.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,9 @@ LIBHELP: OVERVIEW: LLVM Lib
1717
# RUN: env LLD_IN_TEST=1 not lld-link /WX /lib 2>&1 | FileCheck -check-prefix=LIBBAD %s
1818
LIBBAD: ignoring /lib since it's not the first argument
1919

20+
# RUN: env LLD_IN_TEST=1 not lld-link /link 2>&1 | FileCheck -check-prefix=LINKBAD %s
21+
LINKBAD: ignoring /link, did you pass it multiple times?
22+
2023
# RUN: yaml2obj %p/Inputs/hello32.yaml -o %t.obj
2124
# RUN: not lld-link /out:/ %t.obj 2>&1 | FileCheck -check-prefix=DIR %s
2225
DIR: cannot open output file

lldb/bindings/lua/lua-typemaps.swig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ LLDB_NUMBER_TYPEMAP(enum SWIGTYPE);
252252
luaL_Stream *p = (luaL_Stream *)luaL_checkudata(L, $input, LUA_FILEHANDLE);
253253
lldb::FileSP file_sp;
254254
file_sp = std::make_shared<lldb_private::NativeFile>(
255-
p->f, lldb_private::NativeFile::eOpenOptionReadWrite, false);
255+
p->f, lldb_private::NativeFile::eOpenOptionWriteOnly, false);
256256
if (!file_sp->IsValid())
257257
return luaL_error(L, "Invalid file");
258258
$1 = file_sp;

llvm/lib/Transforms/Utils/ScalarEvolutionExpander.cpp

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2208,17 +2208,6 @@ Value *SCEVExpander::generateOverflowCheck(const SCEVAddRecExpr *AR,
22082208
// negative. If Step is known to be positive or negative, only create
22092209
// either 1. or 2.
22102210
auto ComputeEndCheck = [&]() -> Value * {
2211-
// Checking <u 0 is always false, if (Step * trunc ExitCount) does not wrap.
2212-
// TODO: Predicates that can be proven true/false should be discarded when
2213-
// the predicates are created, not late during expansion.
2214-
if (!Signed && Start->isZero() && SE.isKnownPositive(Step) &&
2215-
DstBits < SrcBits &&
2216-
ExitCount == SE.getZeroExtendExpr(SE.getTruncateExpr(ExitCount, ARTy),
2217-
ExitCount->getType()) &&
2218-
SE.willNotOverflow(Instruction::Mul, Signed, Step,
2219-
SE.getTruncateExpr(ExitCount, ARTy)))
2220-
return ConstantInt::getFalse(Loc->getContext());
2221-
22222211
// Get the backedge taken count and truncate or extended to the AR type.
22232212
Value *TruncTripCount = Builder.CreateZExtOrTrunc(TripCountVal, Ty);
22242213

0 commit comments

Comments
 (0)