Apply suggestions from code review

mayanksolanki393 · nikic · web-flow · commit 05f1e09bdd7e · 2025-06-13T18:36:05.000+05:30
Co-authored-by: Nikita Popov &lt;github@npopov.com&gt;
diff --git a/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp b/llvm/lib/Transforms/InstCombine/InstCombineCasts.cpp
@@ -815,8 +815,7 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst &Trunc) {
       return new ICmpInst(ICmpInst::ICMP_EQ, X, CmpC);
     }
 
-    if (match(Src, m_AShr(m_Value(X), m_SpecificInt(SrcWidth - 1))) ||
-        match(Src, m_LShr(m_Value(X), m_SpecificInt(SrcWidth - 1)))) {
+    if (match(Src, m_Shr(m_Value(X), m_SpecificInt(SrcWidth - 1)))) {
       // trunc (ashr X, BW-1) to i1 --> icmp slt X, 0
       // trunc (lshr X, BW-1) to i1 --> icmp slt X, 0
       return new ICmpInst(ICmpInst::ICMP_SLT, X, Zero);

Original file line number	Diff line number	Diff line change
`@@ -815,8 +815,7 @@ Instruction *InstCombinerImpl::visitTrunc(TruncInst &Trunc) {`
`815`	`815`	`return new ICmpInst(ICmpInst::ICMP_EQ, X, CmpC);`
`816`	`816`	`}`
`817`	`817`
`818`		`- if (match(Src, m_AShr(m_Value(X), m_SpecificInt(SrcWidth - 1))) \|\|`
`819`		`- match(Src, m_LShr(m_Value(X), m_SpecificInt(SrcWidth - 1)))) {`
	`818`	`+ if (match(Src, m_Shr(m_Value(X), m_SpecificInt(SrcWidth - 1)))) {`
`820`	`819`	`// trunc (ashr X, BW-1) to i1 --> icmp slt X, 0`
`821`	`820`	`// trunc (lshr X, BW-1) to i1 --> icmp slt X, 0`
`822`	`821`	`return new ICmpInst(ICmpInst::ICMP_SLT, X, Zero);`